mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2025-02-02 12:32:29 +00:00
videoparsers: h264: Disable passthorugh mode enabling
Enabling passthorugh mode is causing multiple issue: For nal aligned multiresoluton streams, passthrough mode make h264parse unable to advertise the new resoultions. Also causing issues while parsing MVC streams which have two separate layers (base-view and non-base-view). This fix is only a temporary workaround. For MVC, proper fixes needed in many places: (handle prefix nal unit, handle non-base-view slice nal extension, fix the picture_start detection for multi-layer-mvc streams etc) https://bugzilla.gnome.org/show_bug.cgi?id=758656
This commit is contained in:
parent
019bc67837
commit
cf7056a312
1 changed files with 7 additions and 0 deletions
|
@ -2368,6 +2368,12 @@ gst_h264_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
|
|||
}
|
||||
}
|
||||
|
||||
/* Fixme: setting passthrough mode casuing multiple issues:
|
||||
* For nal aligned multiresoluton streams, passthrough mode make h264parse
|
||||
* unable to advertise the new resoultions. Also causing issues while
|
||||
* parsing MVC streams when it has two layers.
|
||||
* Disabing passthourgh mode for now */
|
||||
#if 0
|
||||
/* If SPS/PPS and a keyframe have been parsed, and we're not converting,
|
||||
* we might switch to passthrough mode now on the basis that we've seen
|
||||
* the SEI packets and know optional caps params (such as multiview).
|
||||
|
@ -2379,6 +2385,7 @@ gst_h264_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
|
|||
gst_base_parse_set_passthrough (parse, TRUE);
|
||||
}
|
||||
}
|
||||
#endif
|
||||
|
||||
gst_h264_parse_reset_frame (h264parse);
|
||||
|
||||
|
|
Loading…
Reference in a new issue