mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:46:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtmp2: Need to unescape the userinfo before setting

Browse source 
This regressed in 827afa206d. The same
fix was also committed to the webrtc element, but rtmp2 was missed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1547>
This commit is contained in:
Nirbheek Chauhan 2020-08-29 02:42:12 +05:30 committed by GStreamer Merge Bot
parent 16d84a2816
commit ce18a344f4
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/rtmp2/gstrtmp2locationhandler.c
View file

@ -212,6 +212,7 @@ uri_handler_set_uri (GstURIHandler * handler, const gchar * string,
userinfo = gst_uri_get_userinfo (uri); userinfo = gst_uri_get_userinfo (uri);
if (userinfo) { if (userinfo) {
gchar *user, *pass;
gchar **split = g_strsplit (userinfo, ":", 2); gchar **split = g_strsplit (userinfo, ":", 2);
if (!split || !split[0] || !split[1]) { if (!split || !split[0] || !split[1]) {
@ -226,8 +227,13 @@ uri_handler_set_uri (GstURIHandler * handler, const gchar * string,
"assume that the first ':' delineates user:pass. You should escape " "assume that the first ':' delineates user:pass. You should escape "
"the user and pass before adding to the URI.", userinfo); "the user and pass before adding to the URI.", userinfo);
g_object_set (self, "username", split[0], "password", split[1], NULL); user = g_uri_unescape_string (split[0], NULL);
pass = g_uri_unescape_string (split[1], NULL);
g_strfreev (split); g_strfreev (split);
g_object_set (self, "username", user, "password", pass, NULL);
g_free (user);
g_free (pass);
} }
ret = TRUE; ret = TRUE;