mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-18 05:16:05 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/avi/gstavidemux.c: Add comment in a fultile attempt to stop the copy-and-paste paradigm leading to duplication of...

Browse source 
Original commit message from CVS:
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_event):
Add comment in a fultile attempt to stop the copy-and-paste
paradigm leading to duplication of bad code.

* gst/rtsp/rtsptransport.c: (rtsp_transport_parse):
Mime parameters have to be checked case insensitive
This commit is contained in:
Wim Taymans 2006-02-15 10:15:47 +00:00
parent 484c2cc160
commit ccfc0d947c
3 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2006-02-15 Wim Taymans <wim@fluendo.com>
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_event):
Add comment in a fultile attempt to stop the copy-and-paste
paradigm leading to duplication of bad code.
* gst/rtsp/rtsptransport.c: (rtsp_transport_parse):
Mime parameters have to be checked case insensitive
2006-02-14 Tim-Philipp Müller <tim at centricular dot net> 2006-02-14 Tim-Philipp Müller <tim at centricular dot net>
* gst/matroska/matroska-demux.c: (gst_matroska_demux_sync_streams): * gst/matroska/matroska-demux.c: (gst_matroska_demux_sync_streams):

2
gst/avi/gstavidemux.c
View file

@ -455,6 +455,8 @@ gst_avi_demux_handle_src_event (GstPad * pad, GstEvent * event)
switch (GST_EVENT_TYPE (event)) { switch (GST_EVENT_TYPE (event)) {
case GST_EVENT_SEEK: case GST_EVENT_SEEK:
{ {
/* FIXME, this seeking code is not correct, look at wavparse for
* a better example */
GstFormat format; GstFormat format;
GstSeekFlags flags; GstSeekFlags flags;
gdouble rate; gdouble rate;

14
gst/rtsp/rtsptransport.c
View file

@ -80,7 +80,7 @@ parse_range (RTSPTransport * transport, gchar * str, RTSPRange * range)
RTSPResult RTSPResult
rtsp_transport_parse (gchar * str, RTSPTransport * transport) rtsp_transport_parse (gchar * str, RTSPTransport * transport)
{ {
gchar **split; gchar **split, *down;
gint i; gint i;
if (str == NULL || transport == NULL) if (str == NULL || transport == NULL)
@ -88,14 +88,17 @@ rtsp_transport_parse (gchar * str, RTSPTransport * transport)
rtsp_transport_init (transport); rtsp_transport_init (transport);
split = g_strsplit (str, ";", 0); /* case insensitive */
down = g_ascii_strdown (str, -1);
split = g_strsplit (down, ";", 0);
i = 0; i = 0;
while (split[i]) { while (split[i]) {
if (g_str_has_prefix (split[i], "RTP/AVP/UDP")) { if (g_str_has_prefix (split[i], "rtp/avp/udp")) {
transport->lower_transport = RTSP_LOWER_TRANS_UDP; transport->lower_transport = RTSP_LOWER_TRANS_UDP;
} else if (g_str_has_prefix (split[i], "RTP/AVP/TCP")) { } else if (g_str_has_prefix (split[i], "rtp/avp/tcp")) {
transport->lower_transport = RTSP_LOWER_TRANS_TCP; transport->lower_transport = RTSP_LOWER_TRANS_TCP;
} else if (g_str_has_prefix (split[i], "RTP/AVP")) { } else if (g_str_has_prefix (split[i], "rtp/avp")) {
transport->lower_transport = RTSP_LOWER_TRANS_UDP; transport->lower_transport = RTSP_LOWER_TRANS_UDP;
} else if (g_str_has_prefix (split[i], "multicast")) { } else if (g_str_has_prefix (split[i], "multicast")) {
transport->multicast = TRUE; transport->multicast = TRUE;
@ -130,6 +133,7 @@ rtsp_transport_parse (gchar * str, RTSPTransport * transport)
i++; i++;
} }
g_strfreev (split); g_strfreev (split);
g_free (down);
return RTSP_OK; return RTSP_OK;
} }