mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-03 05:59:10 +00:00
Code Issues 1 Projects Releases Wiki Activity

videoconvertscale: Don't passthrough with dither or alpha settings

Browse source 
If the configured properties request dithering/quantization be applied
or alpha be set/multiplied then don't do passthrough, even if the
caps are the same.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5183>
This commit is contained in:
Jan Schmidt 2023-08-14 23:53:01 +10:00 committed by GStreamer Marge Bot
parent 601e31fe6e
commit ccfbdcad90
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
subprojects/gst-plugins-base/gst/videoconvertscale/gstvideoconvertscale.c
View file

@ -766,13 +766,22 @@ gst_video_convert_scale_set_info (GstVideoFilter * filter, GstCaps * in,
goto format_mismatch; goto format_mismatch;
/* if the only thing different in the caps is the transfer function, and /* if the only thing different in the caps is the transfer function, and
* we're converting between equivalent transfer functions, do passthrough */ * we're converting between equivalent transfer functions and not
* quantizing/dithering or adjusting alpha, then do passthrough */
tmp_info = *in_info; tmp_info = *in_info;
tmp_info.colorimetry.transfer = out_info->colorimetry.transfer; tmp_info.colorimetry.transfer = out_info->colorimetry.transfer;
gboolean need_dither = (priv->dither_quantization > 1)
&& (priv->dither != GST_VIDEO_DITHER_NONE);
gboolean need_alpha = GST_VIDEO_INFO_HAS_ALPHA (out_info)
&& ((priv->alpha_mode == GST_VIDEO_ALPHA_MODE_SET) ||
(priv->alpha_mode == GST_VIDEO_ALPHA_MODE_MULT
&& priv->alpha_value != 1.0));
if (gst_video_info_is_equal (&tmp_info, out_info) && if (gst_video_info_is_equal (&tmp_info, out_info) &&
gst_video_transfer_function_is_equivalent (in_info->colorimetry.transfer, gst_video_transfer_function_is_equivalent (in_info->colorimetry.transfer,
in_info->finfo->bits, out_info->colorimetry.transfer, in_info->finfo->bits, out_info->colorimetry.transfer,
out_info->finfo->bits)) { out_info->finfo->bits) && !need_dither && !need_alpha) {
gst_base_transform_set_passthrough (GST_BASE_TRANSFORM (filter), TRUE); gst_base_transform_set_passthrough (GST_BASE_TRANSFORM (filter), TRUE);
} else { } else {
GstStructure *options; GstStructure *options;