mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

mpegtsdemux: fix minor memory leak in property getter

Browse source 
Don't leak the string returned by g_strjoinv(). While we're at it,
use GString to assemble the string to be returned.
This commit is contained in:
Tim-Philipp Müller 2010-03-15 10:13:19 +00:00
parent f1fde2ed4b
commit cadb0526d5
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gst/mpegdemux/gstmpegtsdemux.c
View file

@ -3224,15 +3224,15 @@ gst_mpegts_demux_get_property (GObject * object, guint prop_id,
if (demux->nb_elementary_pids == 0) { if (demux->nb_elementary_pids == 0) {
g_value_set_static_string (value, ""); g_value_set_static_string (value, "");
} else { } else {
gchar **ts_pids; GString *ts_pids;
ts_pids = g_new0 (gchar *, demux->nb_elementary_pids + 1); ts_pids = g_string_sized_new (32);
for (i = 0; i < demux->nb_elementary_pids; i++) { /* FIXME: align with property description which uses hex numbers? */
ts_pids[i] = g_strdup_printf ("%d", demux->elementary_pids[i]); g_string_append_printf (ts_pids, "%d", demux->elementary_pids[0]);
for (i = 1; i < demux->nb_elementary_pids; i++) {
g_string_append_printf (ts_pids, ":%d", demux->elementary_pids[i]);
} }
g_value_take_string (value, g_string_free (ts_pids, FALSE));
g_value_set_string (value, g_strjoinv (":", ts_pids));
g_strfreev (ts_pids);
} }
break; break;
case PROP_CHECK_CRC: case PROP_CHECK_CRC: