mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 03:19:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs: encoder: h264: set profile via capsfilter

Browse source 
Until now, the encoder ignored the profile in src caps and chose one
according with the given parameters. But the encoder must honor the
profile specifed in src caps.

This patch do that, and if the encoder needs to choose the profile,
it will do it by following these rules:

1\ If given parameters are not compatible with given profile, the
   encoder will bail out with an error.
2\ The encoder will choose the higher profile indicated in the
   src caps.

https://bugzilla.gnome.org/show_bug.cgi?id=757941
This commit is contained in:
Hyunjun Ko 2017-06-27 16:03:37 +09:00 committed by Víctor Manuel Jáquez Leal
parent d018f64cbd
commit ca84fd211a
1 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
gst-libs/gst/vaapi/gstvaapiencoder_h264.c
View file

@ -1043,24 +1043,34 @@ ensure_profile_limits (GstVaapiEncoderH264 * encoder)
GstVaapiProfile profile; GstVaapiProfile profile;
if (!encoder->max_profile_idc if (!encoder->max_profile_idc
|| encoder->profile_idc <= encoder->max_profile_idc) || encoder->profile_idc == encoder->max_profile_idc)
return TRUE; return TRUE;
GST_WARNING ("lowering coding tools to meet target decoder constraints"); /* Give an error if the given parameters are invalid for requested
* profile rather than lowering profile.
*/
if (encoder->profile_idc > encoder->max_profile_idc) {
GST_WARNING ("Invalid parameter for maximum profile");
return FALSE;
}
profile = GST_VAAPI_PROFILE_UNKNOWN; profile = GST_VAAPI_PROFILE_UNKNOWN;
/* Try Main profile coding tools */ if (encoder->profile_idc < encoder->max_profile_idc) {
if (encoder->max_profile_idc < GST_H264_PROFILE_HIGH) { /* Let profile be higher to fit in the maximum profile
encoder->use_dct8x8 = FALSE; * without changing parameters */
if (encoder->max_profile_idc > GST_H264_PROFILE_BASELINE)
profile = GST_VAAPI_PROFILE_H264_MAIN; profile = GST_VAAPI_PROFILE_H264_MAIN;
}
/* Try Constrained Baseline profile coding tools */ if (encoder->max_profile_idc > GST_H264_PROFILE_MAIN)
if (encoder->max_profile_idc < GST_H264_PROFILE_MAIN) { profile = GST_VAAPI_PROFILE_H264_HIGH;
encoder->num_bframes = 0;
encoder->use_cabac = FALSE; if (encoder->max_profile_idc > GST_H264_PROFILE_HIGH) {
profile = GST_VAAPI_PROFILE_H264_CONSTRAINED_BASELINE; if (encoder->num_views > 2)
profile = GST_VAAPI_PROFILE_H264_MULTIVIEW_HIGH;
else if (encoder->num_views == 2)
profile = GST_VAAPI_PROFILE_H264_STEREO_HIGH;
}
} }
if (profile) { if (profile) {