mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-07 23:25:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

uvch264src: Check return values of all xu_query calls

Browse source 
And use warnings/returns like for other calls

CID #1373414
CID #1373417
This commit is contained in:
Edward Hervey 2017-11-24 08:06:52 +01:00 committed by Edward Hervey
parent b27bdc1786
commit c9acaae376
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
sys/uvch264/gstuvch264_src.c
View file

@ -753,8 +753,9 @@ gst_uvc_h264_src_get_property (GObject * object,
case PROP_LEAKY_BUCKET_SIZE:
fill_probe_commit (self, &probe, 0, 0, 0, 0, 0);
if (GST_STATE (self) >= GST_STATE_PAUSED) {
xu_query (self, UVCX_VIDEO_CONFIG_PROBE, UVC_GET_CUR,
(guchar *) & probe);
if (!xu_query (self, UVCX_VIDEO_CONFIG_PROBE, UVC_GET_CUR,
(guchar *) & probe))
GST_WARNING_OBJECT (self, "probe_setting GET_CUR error");
}
break;
default:
@ -1323,7 +1324,11 @@ gst_uvc_h264_src_get_enum_setting (GstUvcH264Src * self, gchar * property,
*default_value = def;
*mask = 0;
xu_query (self, UVCX_RATE_CONTROL_MODE, UVC_GET_CUR, (guchar *) & cur);
if (!xu_query (self, UVCX_RATE_CONTROL_MODE, UVC_GET_CUR,
(guchar *) & cur)) {
GST_WARNING_OBJECT (self, " CONTROL_MODE GET_CUR error");
return FALSE;
}
for (en = min; en <= max; en++) {
uvcx_rate_control_mode_t req = { 0, en };
@ -1334,7 +1339,11 @@ gst_uvc_h264_src_get_enum_setting (GstUvcH264Src * self, gchar * property,
(guchar *) & req) && req.bRateControlMode == en)
*mask |= (1 << en);
}
xu_query (self, UVCX_RATE_CONTROL_MODE, UVC_SET_CUR, (guchar *) & cur);
if (!xu_query (self, UVCX_RATE_CONTROL_MODE, UVC_SET_CUR,
(guchar *) & cur)) {
GST_WARNING_OBJECT (self, " CONTROL_MODE SET_CUR error");
return FALSE;
}
}
}