mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-30 11:50:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

ges: Place imagefreeze at right place

Browse source 
Negotiation fails when having the imagefreeze after videorate and
frame positioning won't happen after seeks if we do not put it
before the postioner
This commit is contained in:
Thibault Saunier 2020-04-11 11:40:06 -04:00 committed by GStreamer Merge Bot
parent d1444581f6
commit c940333d18
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ges/ges-image-source.c
View file

@ -97,7 +97,7 @@ ges_image_source_dispose (GObject * object)
}
static void
pad_added_cb (GstElement * timeline, GstPad * pad, GstElement * scale)
pad_added_cb (GstElement * source, GstPad * pad, GstElement * scale)
{
GstPad *sinkpad;
GstPadLinkReturn ret;

19
ges/ges-video-uri-source.c
View file

@ -216,6 +216,13 @@ G_DEFINE_TYPE_WITH_CODE (GESVideoUriSource, ges_video_uri_source,
G_IMPLEMENT_INTERFACE (GES_TYPE_EXTRACTABLE,
ges_extractable_interface_init));
static gboolean
_find_positioner (GstElement * a, GstElement * b)
{
return !g_strcmp0 (GST_OBJECT_NAME (gst_element_get_factory (a)),
"framepositioner");
}
/* GObject VMethods */
static gboolean
@ -229,8 +236,16 @@ ges_video_uri_source_create_filters (GESVideoSource * source,
->ABI.abi.create_filters (source, elements, needs_converters))
return FALSE;
if (ges_uri_source_asset_is_image (GES_URI_SOURCE_ASSET (asset)))
g_ptr_array_add (elements, gst_element_factory_make ("imagefreeze", NULL));
if (ges_uri_source_asset_is_image (GES_URI_SOURCE_ASSET (asset))) {
guint i;
g_ptr_array_find_with_equal_func (elements, NULL,
(GEqualFunc) _find_positioner, &i);
/* Adding the imagefreeze right before the positionner so positioning can happen
* properly */
g_ptr_array_insert (elements, i,
gst_element_factory_make ("imagefreeze", NULL));
}
return TRUE;
}