mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

pluginloader: Don't leak pluginloader in error cases

Browse source 
CID #1212154
This commit is contained in:
Edward Hervey 2014-05-12 17:03:46 +02:00
parent 25bcc2d7f6
commit c7d68da704
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/gstpluginloader.c
View file

@ -528,6 +528,7 @@ plugin_loader_cleanup_child (GstPluginLoader * l)
gboolean gboolean
_gst_plugin_loader_client_run (void) _gst_plugin_loader_client_run (void)
{ {
gboolean res = TRUE;
GstPluginLoader *l; GstPluginLoader *l;
l = plugin_loader_new (NULL); l = plugin_loader_new (NULL);
@ -544,7 +545,8 @@ _gst_plugin_loader_client_run (void)
dup_fd = dup (0); /* STDIN */ dup_fd = dup (0); /* STDIN */
if (dup_fd == -1) { if (dup_fd == -1) {
GST_ERROR ("Failed to start. Could no dup STDIN, errno %d", errno); GST_ERROR ("Failed to start. Could no dup STDIN, errno %d", errno);
return FALSE; res = FALSE;
goto beach;
} }
l->fd_r.fd = dup_fd; l->fd_r.fd = dup_fd;
close (0); close (0);
@ -552,7 +554,8 @@ _gst_plugin_loader_client_run (void)
dup_fd = dup (1); /* STDOUT */ dup_fd = dup (1); /* STDOUT */
if (dup_fd == -1) { if (dup_fd == -1) {
GST_ERROR ("Failed to start. Could no dup STDOUT, errno %d", errno); GST_ERROR ("Failed to start. Could no dup STDOUT, errno %d", errno);
return FALSE; res = FALSE;
goto beach;
} }
l->fd_w.fd = dup_fd; l->fd_w.fd = dup_fd;
close (1); close (1);
@ -578,9 +581,10 @@ _gst_plugin_loader_client_run (void)
/* Loop, listening for incoming packets on the fd and writing responses */ /* Loop, listening for incoming packets on the fd and writing responses */
while (!l->rx_done && exchange_packets (l)); while (!l->rx_done && exchange_packets (l));
beach:
plugin_loader_free (l); plugin_loader_free (l);
return TRUE; return res;
} }
static void static void