mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

debugqroverlay: fix string leak

Browse source 
g_string_free(.., FALSE) gives us ownership of the string
already, no need to duplicate that again with g_strdup(),
and doing so will leak the string returned by g_string_free()
here. Caught by compiler warnings in newer GLib versions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4273>
This commit is contained in:
Tim-Philipp Müller 2023-03-26 16:49:32 +01:00 committed by GStreamer Marge Bot
parent 330836db8e
commit c798f01fae
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subprojects/gst-plugins-bad/ext/qroverlay/gstdebugqroverlay.c
View file

@ -240,7 +240,7 @@ get_qrcode_content (GstBaseQROverlay * base, GstBuffer * buf,
GstVideoInfo * info, gboolean * reuse_prev) GstVideoInfo * info, gboolean * reuse_prev)
{ {
GstDebugQROverlay *filter = GST_DEBUG_QR_OVERLAY (base); GstDebugQROverlay *filter = GST_DEBUG_QR_OVERLAY (base);
GString *res = g_string_new (NULL); GString *res;
JsonGenerator *jgen; JsonGenerator *jgen;
gchar *framerate_string = g_strdup_printf ("%d/%d", info->fps_n, info->fps_d); gchar *framerate_string = g_strdup_printf ("%d/%d", info->fps_n, info->fps_d);
@ -276,9 +276,10 @@ get_qrcode_content (GstBaseQROverlay * base, GstBuffer * buf,
jgen = json_generator_new (); jgen = json_generator_new ();
json_node_set_object (root, jobj); json_node_set_object (root, jobj);
json_generator_set_root (jgen, root); json_generator_set_root (jgen, root);
res = g_string_new (NULL);
res = json_generator_to_gstring (jgen, res); res = json_generator_to_gstring (jgen, res);
g_object_unref (jgen); g_object_unref (jgen);
filter->frame_number++; filter->frame_number++;
return g_strdup (g_string_free (res, FALSE)); return g_string_free (res, FALSE);
} }