mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

qml: don't use buffers that have invalid contents

Browse source 
If the GL context is not shareable, ignore it.

A future change may also not output the relevant output either.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/983>
This commit is contained in:
Matthew Waters 2021-05-11 20:41:38 +10:00 committed by GStreamer Marge Bot
parent 3b4673eba3
commit c75bd32539
1 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
ext/qt/gstqtoverlay.cc
View file

@ -409,9 +409,33 @@ gst_qt_overlay_prepare_output_buffer (GstBaseTransform * btrans,
GstGLMemory *out_mem;
GstGLSyncMeta *sync_meta;
if (gst_buffer_n_memory (buffer) <= 0) {
GST_ELEMENT_ERROR (btrans, RESOURCE, NOT_FOUND,
(NULL), ("Buffer must have a memory object"));
return GST_FLOW_ERROR;
}
if (qt_overlay->widget) {
qt_overlay->widget->setCaps (bfilter->in_caps);
qt_overlay->widget->setBuffer (buffer);
GstMemory *mem;
GstGLMemory *gl_mem;
qt_overlay->widget->setCaps (bfilter->in_caps);
mem = gst_buffer_peek_memory (buffer, 0);
if (!gst_is_gl_memory (mem)) {
GST_ELEMENT_ERROR (btrans, RESOURCE, NOT_FOUND,
(NULL), ("Input memory must be a GstGLMemory"));
return GST_FLOW_ERROR;
}
gl_mem = (GstGLMemory *) mem;
if (!gst_gl_context_can_share (gl_mem->mem.context, bfilter->context)) {
GST_WARNING_OBJECT (bfilter, "Cannot use the current input texture "
"(input buffer GL context %" GST_PTR_FORMAT " cannot share "
"resources with the configured OpenGL context %" GST_PTR_FORMAT ")",
gl_mem->mem.context, bfilter->context);
} else {
qt_overlay->widget->setBuffer (buffer);
}
}
/* XXX: is this the correct ts to drive the animation */