mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 11:45:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

avidemux: remove dead code

Browse source 
sub may not be NULL in this switch, there is a bail out just
before it if so.

Coverity 206098
This commit is contained in:
Vincent Penquerc'h 2014-04-16 17:04:50 +01:00
parent 937269d02e
commit c6acd6368b
1 changed files with 10 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
gst/avi/gstavidemux.c
View file

@ -2023,6 +2023,7 @@ gst_avi_demux_parse_stream (GstAviDemux * avi, GstBuffer * buf)
gst_riff_vprp *vprp = NULL; gst_riff_vprp *vprp = NULL;
GstEvent *event; GstEvent *event;
gchar *stream_id; gchar *stream_id;
GstMapInfo map;
element = GST_ELEMENT_CAST (avi); element = GST_ELEMENT_CAST (avi);
@ -2216,22 +2217,17 @@ gst_avi_demux_parse_stream (GstAviDemux * avi, GstBuffer * buf)
break; break;
case GST_RIFF_TAG_strn: case GST_RIFF_TAG_strn:
g_free (stream->name); g_free (stream->name);
if (sub != NULL) {
GstMapInfo map;
gst_buffer_map (sub, &map, GST_MAP_READ); gst_buffer_map (sub, &map, GST_MAP_READ);
stream->name = g_strndup ((gchar *) map.data, map.size); stream->name = g_strndup ((gchar *) map.data, map.size);
gst_buffer_unmap (sub, &map); gst_buffer_unmap (sub, &map);
gst_buffer_unref (sub); gst_buffer_unref (sub);
sub = NULL; sub = NULL;
if (avi->globaltags == NULL) if (avi->globaltags == NULL)
avi->globaltags = gst_tag_list_new_empty (); avi->globaltags = gst_tag_list_new_empty ();
gst_tag_list_add (avi->globaltags, GST_TAG_MERGE_REPLACE, gst_tag_list_add (avi->globaltags, GST_TAG_MERGE_REPLACE,
GST_TAG_TITLE, stream->name, NULL); GST_TAG_TITLE, stream->name, NULL);
} else {
stream->name = g_strdup ("");
}
GST_DEBUG_OBJECT (avi, "stream name: %s", stream->name); GST_DEBUG_OBJECT (avi, "stream name: %s", stream->name);
break; break;
case GST_RIFF_IDIT: case GST_RIFF_IDIT: