mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-12-24 09:10:36 +00:00
inputselector: remove always-true check
event can't be NULL, it has been dereferenced by GST_EVENT_TYPE (), and no case frees the pointer. Remove unnecessary check which will always be True. CID #1308955
This commit is contained in:
parent
231e77338c
commit
c635f38cdc
1 changed files with 13 additions and 15 deletions
|
@ -627,21 +627,19 @@ gst_selector_pad_event (GstPad * pad, GstObject * parent, GstEvent * event)
|
|||
GST_INPUT_SELECTOR_UNLOCK (sel);
|
||||
if (new_tags)
|
||||
g_object_notify (G_OBJECT (selpad), "tags");
|
||||
if (event) {
|
||||
if (forward) {
|
||||
GST_DEBUG_OBJECT (pad, "forwarding event");
|
||||
res = gst_pad_push_event (sel->srcpad, event);
|
||||
} else {
|
||||
/* If we aren't forwarding the event because the pad is not the
|
||||
* active_sinkpad, then set the flag on the pad
|
||||
* that says a segment needs sending if/when that pad is activated.
|
||||
* For all other cases, we send the event immediately, which makes
|
||||
* sparse streams and other segment updates work correctly downstream.
|
||||
*/
|
||||
if (GST_EVENT_IS_STICKY (event))
|
||||
selpad->events_pending = TRUE;
|
||||
gst_event_unref (event);
|
||||
}
|
||||
if (forward) {
|
||||
GST_DEBUG_OBJECT (pad, "forwarding event");
|
||||
res = gst_pad_push_event (sel->srcpad, event);
|
||||
} else {
|
||||
/* If we aren't forwarding the event because the pad is not the
|
||||
* active_sinkpad, then set the flag on the pad
|
||||
* that says a segment needs sending if/when that pad is activated.
|
||||
* For all other cases, we send the event immediately, which makes
|
||||
* sparse streams and other segment updates work correctly downstream.
|
||||
*/
|
||||
if (GST_EVENT_IS_STICKY (event))
|
||||
selpad->events_pending = TRUE;
|
||||
gst_event_unref (event);
|
||||
}
|
||||
|
||||
return res;
|
||||
|
|
Loading…
Reference in a new issue