mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

basetextoverlay: Correctly handle empty text buffers

Browse source
This commit is contained in:
Sebastian Dröge 2012-09-27 12:40:51 +02:00
parent dc2f2c9a40
commit c4fb8d1e69
1 changed files with 33 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ext/pango/gstbasetextoverlay.c
View file

@ -2210,6 +2210,7 @@ wait_for_text_buf:
in_text = (gchar *) map.data; in_text = (gchar *) map.data;
in_size = map.size; in_size = map.size;
if (in_size > 0) {
/* g_markup_escape_text() absolutely requires valid UTF8 input, it /* g_markup_escape_text() absolutely requires valid UTF8 input, it
* might crash otherwise. We don't fall back on GST_SUBTITLE_ENCODING * might crash otherwise. We don't fall back on GST_SUBTITLE_ENCODING
* here on purpose, this is something that needs fixing upstream */ * here on purpose, this is something that needs fixing upstream */
@ -2244,6 +2245,10 @@ wait_for_text_buf:
} }
if (in_text != (gchar *) map.data) if (in_text != (gchar *) map.data)
g_free (in_text); g_free (in_text);
} else {
GST_DEBUG_OBJECT (overlay, "No text to render (empty buffer)");
gst_base_text_overlay_render_text (overlay, " ", 1);
}
gst_buffer_unmap (overlay->text_buffer, &map); gst_buffer_unmap (overlay->text_buffer, &map);