mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-05-15 20:58:57 +00:00
Code Issues 1 Projects Releases Wiki Activity

glx: Iterate over FBConfig and select 8 bit color size

Browse source 
Texture upload mechanism used by gstreamer-vaapi relies on 8 bpc.
In latest mesa versions the first fbconfig might not be 8 bit, so iterate
over it to find the correct config with supported values.

This also adds 8 bit alpha size to the framebuffer configuration which is
required to get it working properly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/410>
This commit is contained in:
Rafał Dzięgiel 2021-01-20 10:42:09 +01:00
parent a0a8b8785e
commit c4e76d6fc5
1 changed files with 38 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
gst-libs/gst/vaapi/gstvaapiutils_glx.c
View file

@ -301,9 +301,17 @@ gl_create_context (Display * dpy, int screen, GLContextState * parent)
GLX_RED_SIZE, 8,
GLX_GREEN_SIZE, 8,
GLX_BLUE_SIZE, 8,
GLX_ALPHA_SIZE, 8,
None
};
const GLint rgba_colors[4] = {
GLX_RED_SIZE,
GLX_GREEN_SIZE,
GLX_BLUE_SIZE,
GLX_ALPHA_SIZE
};
cs = malloc (sizeof (*cs));
if (!cs)
goto error;
@ -333,11 +341,38 @@ gl_create_context (Display * dpy, int screen, GLContextState * parent)
if (!fbconfigs)
goto error;
/* Find out a GLXFBConfig compatible with the parent context */
/* Find out a 8 bit GLXFBConfig compatible with the parent context */
for (n = 0; n < n_fbconfigs; n++) {
gboolean sizes_correct = FALSE;
int cn;
status = glXGetFBConfigAttrib (parent->display,
fbconfigs[n], GLX_FBCONFIG_ID, &val);
if (status == Success && val == fbconfig_id)
if (status != Success)
goto error;
if (val != fbconfig_id)
continue;
/* Iterate over RGBA sizes in fbconfig */
for (cn = 0; cn < 4; cn++) {
int size = 0;
status = glXGetFBConfigAttrib (parent->display,
fbconfigs[n], rgba_colors[cn], &size);
if (status != Success)
goto error;
/* Last check is for alpha
* and alpha is optional */
if (cn == 3) {
if (size == 0 || size == 8) {
sizes_correct = TRUE;
break;
}
} else if (size != 8)
break;
}
if (sizes_correct)
break;
}
if (n == n_fbconfigs)
@ -809,6 +844,7 @@ gl_create_pixmap_object (Display * dpy, guint width, guint height)
GLX_RED_SIZE, 8,
GLX_GREEN_SIZE, 8,
GLX_BLUE_SIZE, 8,
GLX_ALPHA_SIZE, 8,
GL_NONE,
};