mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-28 04:31:06 +00:00
Code Issues 1 Projects Releases Wiki Activity

queue: Don't unref GstQuery travelling through the queue

Browse source 
Unlike events and buffers, the reference is not given to us
This commit is contained in:
Edward Hervey 2012-03-29 17:43:17 +02:00
parent 617a8b3811
commit c36748177f
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
plugins/elements/gstqueue.c
View file

@ -442,8 +442,10 @@ gst_queue_finalize (GObject * object)
GST_DEBUG_OBJECT (queue, "finalizing queue"); GST_DEBUG_OBJECT (queue, "finalizing queue");
while ((data = g_queue_pop_head (&queue->queue))) while ((data = g_queue_pop_head (&queue->queue))) {
gst_mini_object_unref (data); if (!GST_IS_QUERY (data))
gst_mini_object_unref (data);
}
g_queue_clear (&queue->queue); g_queue_clear (&queue->queue);
g_mutex_clear (&queue->qlock); g_mutex_clear (&queue->qlock);
@ -557,7 +559,8 @@ gst_queue_locked_flush (GstQueue * queue)
while ((data = g_queue_pop_head (&queue->queue))) { while ((data = g_queue_pop_head (&queue->queue))) {
/* Then lose another reference because we are supposed to destroy that /* Then lose another reference because we are supposed to destroy that
data when flushing */ data when flushing */
gst_mini_object_unref (data); if (!GST_IS_QUERY (data))
gst_mini_object_unref (data);
} }
GST_QUEUE_CLEAR_LEVEL (queue->cur_level); GST_QUEUE_CLEAR_LEVEL (queue->cur_level);
queue->min_threshold.buffers = queue->orig_min_threshold.buffers; queue->min_threshold.buffers = queue->orig_min_threshold.buffers;
@ -853,7 +856,8 @@ gst_queue_leak_downstream (GstQueue * queue)
GST_CAT_DEBUG_OBJECT (queue_dataflow, queue, GST_CAT_DEBUG_OBJECT (queue_dataflow, queue,
"queue is full, leaking item %p on downstream end", leak); "queue is full, leaking item %p on downstream end", leak);
gst_mini_object_unref (leak); if (!GST_IS_QUERY (leak))
gst_mini_object_unref (leak);
/* last buffer needs to get a DISCONT flag */ /* last buffer needs to get a DISCONT flag */
queue->head_needs_discont = TRUE; queue->head_needs_discont = TRUE;