mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-05 09:00:54 +00:00
Code Issues 1 Projects Releases Wiki Activity

gsturi: When setting the same string again do nothing

Browse source 
Otherwise code like gst_uri_set_host(uri, gst_uri_get_host(uri)) would
first free the string, then create a copy of the freed string and then
assigned that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3081>
This commit is contained in:
Sebastian Dröge 2022-09-26 14:17:18 +03:00 committed by Tim-Philipp Müller
parent 0589e3ca80
commit c2c20d2437
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
subprojects/gstreamer/gst/gsturi.c
View file

@ -2166,6 +2166,9 @@ gst_uri_set_scheme (GstUri * uri, const gchar * scheme)
return scheme == NULL;
g_return_val_if_fail (GST_IS_URI (uri) && gst_uri_is_writable (uri), FALSE);
if (uri->scheme == scheme)
return TRUE;
g_free (uri->scheme);
uri->scheme = g_strdup (scheme);
@ -2208,6 +2211,8 @@ gst_uri_set_userinfo (GstUri * uri, const gchar * userinfo)
return userinfo == NULL;
g_return_val_if_fail (GST_IS_URI (uri) && gst_uri_is_writable (uri), FALSE);
if (uri->userinfo == userinfo)
return TRUE;
g_free (uri->userinfo);
uri->userinfo = g_strdup (userinfo);
@ -2250,6 +2255,9 @@ gst_uri_set_host (GstUri * uri, const gchar * host)
return host == NULL;
g_return_val_if_fail (GST_IS_URI (uri) && gst_uri_is_writable (uri), FALSE);
if (uri->host == host)
return TRUE;
g_free (uri->host);
uri->host = g_strdup (host);
@ -2669,6 +2677,9 @@ gst_uri_set_query_table (GstUri * uri, GHashTable * query_table)
return query_table == NULL;
g_return_val_if_fail (GST_IS_URI (uri) && gst_uri_is_writable (uri), FALSE);
if (uri->query == query_table)
return TRUE;
old_table = uri->query;
if (query_table)
uri->query = g_hash_table_ref (query_table);
@ -2853,6 +2864,9 @@ gst_uri_set_fragment (GstUri * uri, const gchar * fragment)
return fragment == NULL;
g_return_val_if_fail (GST_IS_URI (uri) && gst_uri_is_writable (uri), FALSE);
if (uri->fragment == fragment)
return TRUE;
g_free (uri->fragment);
uri->fragment = g_strdup (fragment);
return TRUE;