mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

subparse: don't try to index string with -1

Browse source 
If the len of the string turns out to be 0, str[len - 1] resolved to
str[-1] which is not a good idea.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46543
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2147>
This commit is contained in:
Matthew Waters 2022-04-10 10:55:02 +10:00
parent aa121fd120
commit c2ac57f6c9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gst-plugins-base/gst/subparse/gstsubparseelement.c
View file

@ -187,7 +187,7 @@ gst_sub_parse_data_format_autodetect (gchar * match_str)
if (sscanf (str, "[%u:%02u.%02u]", &n1, &n2, &n3) == 3 || if (sscanf (str, "[%u:%02u.%02u]", &n1, &n2, &n3) == 3 ||
sscanf (str, "[%u:%02u.%03u]", &n1, &n2, &n3) == 3) { sscanf (str, "[%u:%02u.%03u]", &n1, &n2, &n3) == 3) {
all_lines_good = TRUE; all_lines_good = TRUE;
} else if (str[len - 1] == ']' && strchr (str, ':') != NULL) { } else if (len > 0 && str[len - 1] == ']' && strchr (str, ':') != NULL) {
all_lines_good = TRUE; all_lines_good = TRUE;
} else { } else {
all_lines_good = FALSE; all_lines_good = FALSE;