mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 09:40:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

registry: don't forget to clean up registry temp file in another error case

Browse source 
Also clean up temp file if we get an error during write() rather
than just when doing fsync() or close().
This commit is contained in:
Tim-Philipp Müller 2012-02-24 23:19:51 +00:00
parent 0e8a77f83d
commit c25b8e153d
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/gstregistrybinary.c
View file

@ -245,13 +245,14 @@ gst_registry_binary_cache_finish (BinaryRegistryCache * cache, gboolean success)
if (close (cache->cache_fd) < 0) if (close (cache->cache_fd) < 0)
goto close_failed; goto close_failed;
if (success) { if (!success)
goto fail_after_close;
/* Only do the rename if we wrote the entire file successfully */ /* Only do the rename if we wrote the entire file successfully */
if (g_rename (cache->tmp_location, cache->location) < 0) { if (g_rename (cache->tmp_location, cache->location) < 0) {
GST_ERROR ("g_rename() failed: %s", g_strerror (errno)); GST_ERROR ("g_rename() failed: %s", g_strerror (errno));
goto rename_failed; goto rename_failed;
} }
}
g_free (cache->tmp_location); g_free (cache->tmp_location);
g_slice_free (BinaryRegistryCache, cache); g_slice_free (BinaryRegistryCache, cache);