mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-28 23:02:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2: object: Handle video helper return value

Browse source 
gst_video_info_set_interlaced_format() can return an error if the
width/height causes integer overflow. Handle this case, so that we can
fail cleanly. This has been experienced while testing an in-progress
driver.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5286>
This commit is contained in:
Nicolas Dufresne 2023-09-05 16:56:44 -04:00
parent 353cb2da92
commit c1e03081c0
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subprojects/gst-plugins-good/sys/v4l2/gstv4l2object.c
View file

@ -4052,7 +4052,7 @@ gst_v4l2_object_set_format_full (GstV4l2Object * v4l2object, GstCaps * caps,
/* Passing HDR10 information
*
* TODO:
* TODO:
* - Missing capture (v4l2src) HDR10 configuration and/or reporting
* - The API is not capable of HDR to HDR conversion as controls are not specific to queues
*/
@ -4580,8 +4580,9 @@ gst_v4l2_object_acquire_format (GstV4l2Object * v4l2object, GstVideoInfo * info)
goto unsupported_field;
}
gst_video_info_set_interlaced_format (info, format, interlace_mode, width,
height);
if (!gst_video_info_set_interlaced_format (info, format, interlace_mode,
width, height))
goto invalid_dimensions;
gst_v4l2_object_get_colorspace (v4l2object, &fmt, &info->colorimetry);
gst_v4l2_object_get_streamparm (v4l2object, info);