mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-28 09:15:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate:launcher: First rely on the presence of criticals to set tests result

Browse source 
In the case of external applications they might not set their exist
code bases on the result of validate so we should rely on what
validates as to say first.
This commit is contained in:
Thibault Saunier 2015-03-04 17:30:41 +01:00
parent 88da04e0a0
commit c0e3d2e4f1
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
validate/launcher/baseclasses.py
View file

@ -415,7 +415,7 @@ class GstValidateTest(Test):
errors.append(error)
if ret == "[":
return "No critical"
return None
else:
return ret + "]"
@ -426,21 +426,22 @@ class GstValidateTest(Test):
self.debug("%s returncode: %s", self, self.process.returncode)
if self.result == Result.TIMEOUT:
self.set_result(Result.TIMEOUT, "Application timed out", "timeout")
elif self.process.returncode == 0:
self.set_result(Result.PASSED)
criticals = self.get_validate_criticals_errors()
if self.process.returncode == 139:
# FIXME Reimplement something like that if needed
# self.get_backtrace("SEGFAULT")
self.set_result(Result.FAILED,
"Application segfaulted",
"segfault")
elif criticals or self.process.returncode != 0:
if criticals is None:
criticals = "No criticals"
self.set_result(Result.FAILED,
"Application returned %s (issues: %s)"
% (self.process.returncode, criticals))
else:
if self.process.returncode == 139:
# FIXME Reimplement something like that if needed
# self.get_backtrace("SEGFAULT")
self.set_result(Result.FAILED,
"Application segfaulted",
"segfault")
else:
self.set_result(Result.FAILED,
"Application returned %s (issues: %s)" % (
self.process.returncode,
self.get_validate_criticals_errors()
))
self.set_result(Result.PASSED)
def _parse_position(self, p):
self.log("Parsing %s" % p)