mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 11:45:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

matroska: Add size checks to the parsing of FLAC headers

Browse source
This commit is contained in:
Sebastian Dröge 2016-11-22 20:01:20 +02:00
parent fec77de8cb
commit c0da05df38
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/matroska/matroska-ids.c
View file

@ -283,15 +283,18 @@ gst_matroska_parse_flac_stream_headers (gpointer codec_data,
/* skip fLaC marker */
off = 4;
/* FIXME: check size remaining */
while (off < codec_data_size) {
while (off < codec_data_size - 3) {
len = GST_READ_UINT8 (pdata + off + 1) << 16;
len |= GST_READ_UINT8 (pdata + off + 2) << 8;
len |= GST_READ_UINT8 (pdata + off + 3);
GST_DEBUG ("header packet: len=%u bytes, flags=0x%02x", len, pdata[off]);
/* FIXME: check size remaining */
if (off + len > codec_data_size) {
gst_buffer_list_unref (list);
return NULL;
}
hdr = gst_buffer_new_wrapped (g_memdup (pdata + off, len + 4), len + 4);
gst_buffer_list_add (list, hdr);