mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-03 14:08:56 +00:00
Code Issues 1 Projects Releases Wiki Activity

GstShmAllocator: Use shm_open() instead of temporary file

Browse source 
There is no guarantee that g_get_user_runtime_dir() is in a tmpfs. Using
an explicit shared memory API seems safer for all POSIX platforms.

Note that Android does not have shm_open() and only added memfd_create()
since API level 30 (Android 11).

Sponsored-by: Netflix Inc.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5328>
This commit is contained in:
Xavier Claessens 2023-09-18 14:38:24 -04:00 committed by GStreamer Marge Bot
parent d59ea1caf0
commit c0ce677dfc
2 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
subprojects/gst-plugins-base/gst-libs/gst/allocators/gstshmallocator.c
View file

@ -52,7 +52,7 @@ static GstMemory *
gst_shm_allocator_alloc (GstAllocator * allocator, gsize size,
GstAllocationParams * params)
{
#ifdef HAVE_MMAP
#if defined(HAVE_MEMFD_CREATE) || defined(HAVE_SHM_OPEN)
GstShmAllocator *self = GST_SHM_ALLOCATOR (allocator);
int fd;
GstMemory *mem;
@ -75,19 +75,17 @@ gst_shm_allocator_alloc (GstAllocator * allocator, gsize size,
{
char filename[1024];
static int init = 0;
int flags = O_RDWR | O_CREAT | O_EXCL;
int perms = S_IRUSR | S_IWUSR | S_IRGRP;
/* allocate shm pool */
snprintf (filename, 1024, "%s/%s-%d-%s", g_get_user_runtime_dir (),
"gst-shm", init++, "XXXXXX");
fd = g_mkstemp (filename);
snprintf (filename, 1024, "/gst-shm.%d.%d", getpid (), init++);
fd = shm_open (filename, flags, perms);
if (fd < 0) {
GST_ERROR_OBJECT (self, "opening temp file %s failed: %s", filename,
strerror (errno));
GST_ERROR_OBJECT (self, "shm_open() failed: %s", strerror (errno));
return NULL;
}
unlink (filename);
shm_unlink (filename);
}
if (ftruncate (fd, size) < 0) {
@ -104,7 +102,7 @@ gst_shm_allocator_alloc (GstAllocator * allocator, gsize size,
return NULL;
}
/* we need to map the memory in order to unlink the file without losing it */
/* Map R/W and keep it mapped to avoid useless mmap/munmap */
if (!gst_memory_map (mem, &info, GST_MAP_READWRITE)) {
GST_ERROR_OBJECT (self, "GstFdMemory map failed");
close (fd);

4
subprojects/gst-plugins-base/gst-libs/gst/allocators/meson.build
View file

@ -28,6 +28,10 @@ if cc.has_function('memfd_create')
'-DHAVE_MEMFD_CREATE',
'-D_GNU_SOURCE',
]
elif cc.has_function('shm_open')
gst_allocators_cargs += [
'-DHAVE_SHM_OPEN',
]
endif
gstallocators = library('gstallocators-@0@'.format(api_version),