mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-11 06:11:27 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "basesrc: Send an update NEWSEGMENT event downstream if the duration changes"

Browse source 
This reverts commit 934faf163c.

Original commit leads to possibly sending newsegment event downstream
in pull mode.  In push mode, quite some downstream elements
are likely to only expect newsegment event following a seek they performed
and as such may have their state messed up.
This commit is contained in:
Mark Nauwelaerts 2011-06-08 20:14:16 +02:00
parent 6d374e54b9
commit c040305b8c
1 changed files with 0 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
libs/gst/base/gstbasesrc.c
View file

@ -2028,7 +2028,6 @@ gst_base_src_update_length (GstBaseSrc * src, guint64 offset, guint * length)
GstBaseSrcClass *bclass;
GstFormat format;
gint64 stop;
gboolean updated = FALSE;
bclass = GST_BASE_SRC_GET_CLASS (src);
@ -2084,33 +2083,10 @@ gst_base_src_update_length (GstBaseSrc * src, guint64 offset, guint * length)
/* keep track of current position and update duration.
* segment is in bytes, we checked that above. */
GST_OBJECT_LOCK (src);
updated = (src->segment.duration != size);
gst_segment_set_duration (&src->segment, GST_FORMAT_BYTES, size);
gst_segment_set_last_stop (&src->segment, GST_FORMAT_BYTES, offset);
GST_OBJECT_UNLOCK (src);
/* If we updated the duration and doing forward playback, we
* have to update the downstream segments to update the stop
* position */
if (updated && src->segment.rate >= 0.0) {
gint64 stop;
GstEvent *event;
/* for deriving a stop position for the playback segment from the seek
* segment, we must take the duration when the stop is not set */
if ((stop = src->segment.stop) == -1)
stop = src->segment.duration;
GST_DEBUG_OBJECT (src, "Sending update newsegment from %" G_GINT64_FORMAT
" to %" G_GINT64_FORMAT, src->segment.start, stop);
event =
gst_event_new_new_segment_full (TRUE,
src->segment.rate, src->segment.applied_rate, src->segment.format,
src->segment.start, stop, src->segment.time);
gst_pad_push_event (src->srcpad, event);
}
return TRUE;
/* ERRORS */