mp4 robust muxing: improve documentation and logging

This commit is contained in:
Mathieu Duponchelle 2018-08-16 18:55:29 +02:00
parent 20758215b5
commit bfcddb7125
2 changed files with 6 additions and 1 deletions

View file

@ -2968,6 +2968,10 @@ gst_qt_mux_start_file (GstQTMux * qtmux)
(NULL)); (NULL));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
if (qtmux->reserved_moov_update_period == GST_CLOCK_TIME_NONE) {
GST_WARNING_OBJECT (qtmux,
"Robust muxing requires reserved-moov-update-period to be set");
}
break; break;
case GST_QT_MUX_MODE_FAST_START: case GST_QT_MUX_MODE_FAST_START:
case GST_QT_MUX_MODE_FRAGMENTED_STREAMABLE: case GST_QT_MUX_MODE_FRAGMENTED_STREAMABLE:

View file

@ -338,7 +338,8 @@ gst_splitmux_sink_class_init (GstSplitMuxSinkClass * klass)
"reserved-duration-remaining properties and use them if so. " "reserved-duration-remaining properties and use them if so. "
"(Only present on qtmux and mp4mux for now). splitmuxsink may then also " "(Only present on qtmux and mp4mux for now). splitmuxsink may then also "
" create new fragments if the reserved header space is about to overflow. " " create new fragments if the reserved header space is about to overflow. "
"Note this does not set reserved-moov-update-period - apps should do that manually", "Note that for mp4mux and qtmux, reserved-moov-update-period must be set "
"manually by the app to a non-zero value for robust muxing to have an effect.",
DEFAULT_USE_ROBUST_MUXING, DEFAULT_USE_ROBUST_MUXING,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));