mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtsp: fail gracefully on bad Content-Length headers

Browse source 
Be careful when allocating the amount of bytes specified in the Content-Length
because it can be an insanely huge value. Try to allocate the memory but fail
gracefully with a nice error when the allocation failed.
This commit is contained in:
Wim Taymans 2010-02-10 16:05:29 +01:00
parent 8b1e42f272
commit be037e0dc8
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gst-libs/gst/rtsp/gstrtspconnection.c
View file

@ -1906,7 +1906,13 @@ build_next (GstRTSPBuilder * builder, GstRTSPMessage * message,
GST_RTSP_HDR_X_SESSIONCOOKIE, NULL, 0) != GST_RTSP_OK)) { GST_RTSP_HDR_X_SESSIONCOOKIE, NULL, 0) != GST_RTSP_OK)) {
/* there is, prepare to read the body */ /* there is, prepare to read the body */
builder->body_len = atol (hdrval); builder->body_len = atol (hdrval);
builder->body_data = g_malloc (builder->body_len + 1); builder->body_data = g_try_malloc (builder->body_len + 1);
/* we can't do much here, we need the length to know how many bytes
* we need to read next and when allocation fails, something is
* probably wrong with the length. */
if (builder->body_data == NULL)
goto invalid_body_len;
builder->body_data[builder->body_len] = '\0'; builder->body_data[builder->body_len] = '\0';
builder->offset = 0; builder->offset = 0;
builder->state = STATE_DATA_BODY; builder->state = STATE_DATA_BODY;
@ -1999,6 +2005,13 @@ build_next (GstRTSPBuilder * builder, GstRTSPMessage * message,
} }
done: done:
return res; return res;
/* ERRORS */
invalid_body_len:
{
GST_DEBUG ("could not allocate body");
return GST_RTSP_ERROR;
}
} }
/** /**