gst/modplug/libmodplug/sndfile.cpp: Fix potential buffer overflow (CVE-2006-4192) (#385788).

Original commit message from CVS:
* gst/modplug/libmodplug/sndfile.cpp:
Fix potential buffer overflow (CVE-2006-4192) (#385788).
This commit is contained in:
Tim-Philipp Müller 2006-12-14 15:45:56 +00:00
parent 22f148e7b8
commit bc2cdd57d5
2 changed files with 6 additions and 1 deletions

View file

@ -1,3 +1,8 @@
2006-12-14 Tim-Philipp Müller <tim at centricular dot net>
* gst/modplug/libmodplug/sndfile.cpp:
Fix potential buffer overflow (CVE-2006-4192) (#385788).
2006-12-13 Wim Taymans <wim@fluendo.com> 2006-12-13 Wim Taymans <wim@fluendo.com>
* gst/qtdemux/qtdemux.c: (gst_qtdemux_get_duration), * gst/qtdemux/qtdemux.c: (gst_qtdemux_get_duration),

View file

@ -1081,7 +1081,7 @@ UINT CSoundFile::ReadSample(MODINSTRUMENT *pIns, UINT nFlags, LPCSTR lpMemFile,
{ {
UINT len = 0, mem = pIns->nLength+6; UINT len = 0, mem = pIns->nLength+6;
if ((!pIns) || (pIns->nLength < 4) || (!lpMemFile)) return 0; if ((!pIns) || ((int)pIns->nLength < 4) || (!lpMemFile)) return 0;
if (pIns->nLength > MAX_SAMPLE_LENGTH) pIns->nLength = MAX_SAMPLE_LENGTH; if (pIns->nLength > MAX_SAMPLE_LENGTH) pIns->nLength = MAX_SAMPLE_LENGTH;
pIns->uFlags &= ~(CHN_16BIT|CHN_STEREO); pIns->uFlags &= ~(CHN_16BIT|CHN_STEREO);
if (nFlags & RSF_16BIT) if (nFlags & RSF_16BIT)