mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-06 10:42:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

registry: fix deadlock with recursive registry scanning.

Browse source 
The way to properly fix this issue was in fact to disable the registry
scanning when we import gst from the python plugin loader since...
we are 100% guaranteed this is being called from a registry scan :)
This commit is contained in:
Edward Hervey 2009-04-12 21:27:33 +02:00
parent 4d8b4c8dd3
commit bbedab4e65
2 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/__init__.py
View file

@ -190,11 +190,6 @@ try:
except:
pass
# disable registry update during initialization
import os
doupdate = os.getenv("GST_REGISTRY_UPDATE") != "no"
os.environ["GST_REGISTRY_UPDATE"] = "no"
from _gst import *
import interfaces
@ -232,8 +227,3 @@ if gstlibtoolimporter is not None:
gstlibtoolimporter.uninstall()
import sys
del sys.modules["gstlibtoolimporter"]
if doupdate:
# update the registry now that we've loaded all symbols
os.unsetenv("GST_REGISTRY_UPDATE")
update_registry()

15
plugin/gstpythonplugin.c
View file

@ -253,6 +253,8 @@ pygst_require (gchar * version)
PyObject *pygst, *gst;
PyObject *require;
PyObject *modules;
gboolean doupdate = TRUE;
const gchar *regupd;
modules = PySys_GetObject ("modules");
/* Try to see if 'gst' is already imported */
@ -273,12 +275,25 @@ pygst_require (gchar * version)
goto error;
}
}
/* We don't want the registry to be loaded when we import gst */
if ((regupd = g_getenv ("GST_REGISTRY_UPDATE"))
&& (!g_strcmp0 (regupd, "no")))
doupdate = FALSE;
g_setenv ("GST_REGISTRY_UPDATE", "no", TRUE);
if (!(gst = PyImport_ImportModule ("gst"))) {
GST_ERROR ("couldn't import the gst module");
Py_DECREF (pygst);
if (doupdate)
g_unsetenv ("GST_REGISTRY_UPDATE");
goto error;
}
}
if (doupdate)
g_unsetenv ("GST_REGISTRY_UPDATE");
#define IMPORT(x, y) \
_PyGst##x##_Type = (PyTypeObject *)PyObject_GetAttrString(gst, y); \
if (_PyGst##x##_Type == NULL) { \