mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-23 22:46:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

pulse: Change bitfield booleans to normal gbooleans

Browse source 
Assigning TRUE (1) to a signed 1 bit integer will cause truncation
from 1 to -1 because the only non-zero value that can be stored is -1
due to how two's-complement works.

As this is a proper GObject let's not bother with all this and simply
use a normal gboolean instead.

../subprojects/gst-plugins-good/ext/pulse/pulsesink.c:1490:19: warning: implicit truncation from 'int' to a one-bit
        wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
  pbuf->in_commit = TRUE;
                  ^ ~~~~

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4617>
This commit is contained in:
Sebastian Dröge 2023-05-12 13:27:19 +03:00 committed by GStreamer Marge Bot
parent f9a3b3eacf
commit bb2c5981fe
3 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
subprojects/gst-plugins-good/ext/pulse/pulsesink.c
View file

@ -178,9 +178,9 @@ struct _GstPulseRingBuffer
gint64 m_offset; gint64 m_offset;
gint64 m_lastoffset; gint64 m_lastoffset;
gboolean corked:1; gboolean corked;
gboolean in_commit:1; gboolean in_commit;
gboolean paused:1; gboolean paused;
}; };
struct _GstPulseRingBufferClass struct _GstPulseRingBufferClass
{ {

6
subprojects/gst-plugins-good/ext/pulse/pulsesink.h
View file

@ -57,9 +57,9 @@ struct _GstPulseSink
GstPulseDeviceInfo device_info; GstPulseDeviceInfo device_info;
gdouble volume; gdouble volume;
gboolean volume_set:1; gboolean volume_set;
gboolean mute:1; gboolean mute;
gboolean mute_set:1; gboolean mute_set;
guint32 current_sink_idx; guint32 current_sink_idx;
gchar *current_sink_name; gchar *current_sink_name;

16
subprojects/gst-plugins-good/ext/pulse/pulsesrc.h
View file

@ -56,19 +56,19 @@ struct _GstPulseSrc
gchar *device_description; gchar *device_description;
gdouble volume; gdouble volume;
gboolean volume_set:1; gboolean volume_set;
gboolean mute:1; gboolean mute;
gboolean mute_set:1; gboolean mute_set;
guint32 current_source_idx; guint32 current_source_idx;
gchar *current_source_name; gchar *current_source_name;
gint notify; /* atomic */ gint notify; /* atomic */
gboolean corked:1; gboolean corked;
gboolean stream_connected:1; gboolean stream_connected;
gboolean operation_success:1; gboolean operation_success;
gboolean paused:1; gboolean paused;
gboolean in_read:1; gboolean in_read;
GstStructure *properties; GstStructure *properties;
pa_proplist *proplist; pa_proplist *proplist;