mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-19 16:21:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: Add details on all g_log message reports.

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-devtools/-/merge_requests/187>
This commit is contained in:
Thibault Saunier 2020-05-03 01:22:04 -04:00
parent b65b2bc2fe
commit bb0d81fd4c
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
validate/gst/validate/gst-validate-report.c
View file

@ -463,11 +463,13 @@ gst_validate_report_load_issues (void)
_
("Pad buffers push frequency is lower than the minimum required by the config"),
NULL);
REGISTER_VALIDATE_ISSUE (WARNING, G_LOG_WARNING, _("We got a g_log warning"),
NULL);
REGISTER_VALIDATE_ISSUE (CRITICAL, G_LOG_CRITICAL,
"We got a g_log critical issue", NULL);
REGISTER_VALIDATE_ISSUE (ISSUE, G_LOG_ISSUE, "We got a g_log issue", NULL);
REGISTER_VALIDATE_ISSUE_FULL (WARNING, G_LOG_WARNING,
_("We got a g_log warning"), NULL, GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS);
REGISTER_VALIDATE_ISSUE_FULL (CRITICAL, G_LOG_CRITICAL,
"We got a g_log critical issue", NULL,
GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS);
REGISTER_VALIDATE_ISSUE_FULL (ISSUE, G_LOG_ISSUE, "We got a g_log issue",
NULL, GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS);
REGISTER_VALIDATE_ISSUE (CRITICAL, PULL_RANGE_FROM_WRONG_THREAD,
"gst_pad_pull_range called from wrong thread",

6
validate/gst/validate/gst-validate-runner.c
View file

@ -764,13 +764,15 @@ _do_report_synthesis (GstValidateRunner * runner)
if (report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) {
criticals = g_list_append (criticals, report);
gst_validate_report_print_details (report);
}
} else if (report->issue->flags & GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS)
gst_validate_report_print_details (report);
for (tmp = g_list_next (reports); tmp; tmp = tmp->next) {
report = (GstValidateReport *) tmp->data;
gst_validate_report_print_detected_on (report);
if (report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) {
if ((report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) ||
(report->issue->flags & GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS)) {
criticals = g_list_append (criticals, report);
gst_validate_report_print_details (report);
}