mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-22 07:08:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

decklink: Don't crash when getting hw serial number doesn't return OK

Browse source 
If the return value isn't OK, it means we might be getting data that
points to an invalid memory address. That shouldn't make us crash.
This commit is contained in:
Vivia Nikolaidou 2017-11-09 00:16:21 +02:00
parent f78be9d698
commit bae9427dc1
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sys/decklink/gstdecklink.cpp
View file

@ -1239,11 +1239,13 @@ init_devices (gpointer data)
devices[i].input.
config->GetString (bmdDeckLinkConfigDeviceInformationSerialNumber,
(COMSTR_T *) & serial_number);
CONVERT_COM_STRING (serial_number);
devices[i].output.hw_serial_number = g_strdup (serial_number);
devices[i].input.hw_serial_number = g_strdup (serial_number);
GST_DEBUG ("device %d has serial number %s", i, serial_number);
FREE_COM_STRING (serial_number);
if (ret == S_OK) {
CONVERT_COM_STRING (serial_number);
devices[i].output.hw_serial_number = g_strdup (serial_number);
devices[i].input.hw_serial_number = g_strdup (serial_number);
GST_DEBUG ("device %d has serial number %s", i, serial_number);
FREE_COM_STRING (serial_number);
}
}
ret = decklink->QueryInterface (IID_IDeckLinkAttributes,