check/Makefile.am: Enable valgrind check that should work fine now.

Original commit message from CVS:
* check/Makefile.am:
Enable valgrind check that should work fine now.

* gst/elements/gsttypefindelement.c: (gst_type_find_element_init):
* gst/gstqueue.c: (gst_queue_init):
Fix memleaks in pad allocation.
This commit is contained in:
Wim Taymans 2005-11-16 17:18:34 +00:00
parent 4258474de2
commit b9eaa6aebe
8 changed files with 24 additions and 27 deletions

View file

@ -1,3 +1,12 @@
2005-11-16 Wim Taymans <wim@fluendo.com>
* check/Makefile.am:
Enable valgrind check that should work fine now.
* gst/elements/gsttypefindelement.c: (gst_type_find_element_init):
* gst/gstqueue.c: (gst_queue_init):
Fix memleaks in pad allocation.
2005-11-16 Andy Wingo <wingo@pobox.com>
* gst/net/Makefile.am:

View file

@ -88,7 +88,6 @@ net_gstnettimeprovider_LDADD = \
VALGRIND_TO_FIX = \
elements/fakesrc \
gst/gstevent \
generic/states \
gst-libs/controller \
pipelines/simple_launch_lines

2
common

@ -1 +1 @@
Subproject commit 657b549dfb640a76f3d7ab7676e453c801a83dca
Subproject commit 3aa0adc0cc4539ec9bb62ccf6d535240dad19e58

View file

@ -204,11 +204,10 @@ static void
gst_type_find_element_init (GstTypeFindElement * typefind,
GstTypeFindElementClass * g_class)
{
GstPadTemplate *sink_template, *src_template;
/* sinkpad */
src_template = gst_static_pad_template_get (&type_find_element_sink_template);
typefind->sink = gst_pad_new_from_template (src_template, "sink");
typefind->sink =
gst_pad_new_from_static_template (&type_find_element_sink_template,
"sink");
gst_pad_set_activate_function (typefind->sink,
GST_DEBUG_FUNCPTR (gst_type_find_element_activate));
@ -219,8 +218,8 @@ gst_type_find_element_init (GstTypeFindElement * typefind,
gst_element_add_pad (GST_ELEMENT (typefind), typefind->sink);
/* srcpad */
sink_template = gst_static_pad_template_get (&type_find_element_src_template);
typefind->src = gst_pad_new_from_template (sink_template, "src");
typefind->src =
gst_pad_new_from_static_template (&type_find_element_src_template, "src");
gst_pad_set_activatepull_function (typefind->src,
GST_DEBUG_FUNCPTR (gst_type_find_element_activate_src_pull));

View file

@ -331,10 +331,7 @@ gst_queue_class_init (GstQueueClass * klass)
static void
gst_queue_init (GstQueue * queue)
{
GstPadTemplate *sink_template, *src_template;
sink_template = gst_static_pad_template_get (&sinktemplate);
queue->sinkpad = gst_pad_new_from_template (sink_template, "sink");
queue->sinkpad = gst_pad_new_from_static_template (&sinktemplate, "sink");
gst_pad_set_chain_function (queue->sinkpad,
GST_DEBUG_FUNCPTR (gst_queue_chain));
@ -350,8 +347,7 @@ gst_queue_init (GstQueue * queue)
GST_DEBUG_FUNCPTR (gst_queue_bufferalloc));
gst_element_add_pad (GST_ELEMENT (queue), queue->sinkpad);
src_template = gst_static_pad_template_get (&srctemplate);
queue->srcpad = gst_pad_new_from_template (src_template, "src");
queue->srcpad = gst_pad_new_from_static_template (&srctemplate, "src");
gst_pad_set_activatepush_function (queue->srcpad,
GST_DEBUG_FUNCPTR (gst_queue_src_activate_push));

View file

@ -331,10 +331,7 @@ gst_queue_class_init (GstQueueClass * klass)
static void
gst_queue_init (GstQueue * queue)
{
GstPadTemplate *sink_template, *src_template;
sink_template = gst_static_pad_template_get (&sinktemplate);
queue->sinkpad = gst_pad_new_from_template (sink_template, "sink");
queue->sinkpad = gst_pad_new_from_static_template (&sinktemplate, "sink");
gst_pad_set_chain_function (queue->sinkpad,
GST_DEBUG_FUNCPTR (gst_queue_chain));
@ -350,8 +347,7 @@ gst_queue_init (GstQueue * queue)
GST_DEBUG_FUNCPTR (gst_queue_bufferalloc));
gst_element_add_pad (GST_ELEMENT (queue), queue->sinkpad);
src_template = gst_static_pad_template_get (&srctemplate);
queue->srcpad = gst_pad_new_from_template (src_template, "src");
queue->srcpad = gst_pad_new_from_static_template (&srctemplate, "src");
gst_pad_set_activatepush_function (queue->srcpad,
GST_DEBUG_FUNCPTR (gst_queue_src_activate_push));

View file

@ -204,11 +204,10 @@ static void
gst_type_find_element_init (GstTypeFindElement * typefind,
GstTypeFindElementClass * g_class)
{
GstPadTemplate *sink_template, *src_template;
/* sinkpad */
src_template = gst_static_pad_template_get (&type_find_element_sink_template);
typefind->sink = gst_pad_new_from_template (src_template, "sink");
typefind->sink =
gst_pad_new_from_static_template (&type_find_element_sink_template,
"sink");
gst_pad_set_activate_function (typefind->sink,
GST_DEBUG_FUNCPTR (gst_type_find_element_activate));
@ -219,8 +218,8 @@ gst_type_find_element_init (GstTypeFindElement * typefind,
gst_element_add_pad (GST_ELEMENT (typefind), typefind->sink);
/* srcpad */
sink_template = gst_static_pad_template_get (&type_find_element_src_template);
typefind->src = gst_pad_new_from_template (sink_template, "src");
typefind->src =
gst_pad_new_from_static_template (&type_find_element_src_template, "src");
gst_pad_set_activatepull_function (typefind->src,
GST_DEBUG_FUNCPTR (gst_type_find_element_activate_src_pull));

View file

@ -88,7 +88,6 @@ net_gstnettimeprovider_LDADD = \
VALGRIND_TO_FIX = \
elements/fakesrc \
gst/gstevent \
generic/states \
gst-libs/controller \
pipelines/simple_launch_lines