mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-24 08:50:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

codecs: gstvp9statefulparser: feature_data should be 0 if feature_enable is 0

Browse source 
The spec says in 6.2.11 that feature_data[i][j] should be zero if
feature_enabled[i][j] is zero. Instead we retained the old value in the parser.
Fix it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2449>
This commit is contained in:
Daniel Almeida 2021-07-29 12:20:30 -03:00 committed by GStreamer Marge Bot
parent 8239ff343f
commit b8c826afe3
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gst-libs/gst/codecs/gstvp9statefulparser.c
View file

@ -727,12 +727,18 @@ parse_segmentation_params (GstBitReader * br, GstVp9SegmentationParams * params)
for (i = 0; i < GST_VP9_MAX_SEGMENTS; i++) {
VP9_READ_BIT (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_Q]);
if (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_Q])
if (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_Q]) {
VP9_READ_SIGNED_16 (params->feature_data[i][GST_VP9_SEG_LVL_ALT_Q], 8);
} else {
params->feature_data[i][GST_VP9_SEG_LVL_ALT_Q] = 0;
}
VP9_READ_BIT (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_L]);
if (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_L])
if (params->feature_enabled[i][GST_VP9_SEG_LVL_ALT_L]) {
VP9_READ_SIGNED_8 (params->feature_data[i][GST_VP9_SEG_LVL_ALT_L], 6);
} else {
params->feature_data[i][GST_VP9_SEG_LVL_ALT_L] = 0;
}
VP9_READ_BIT (params->feature_enabled[i][GST_VP9_SEG_LVL_REF_FRAME]);
if (params->feature_enabled[i][GST_VP9_SEG_LVL_REF_FRAME]) {
@ -740,6 +746,8 @@ parse_segmentation_params (GstBitReader * br, GstVp9SegmentationParams * params)
VP9_READ_UINT8 (val, 2);
params->feature_data[i][GST_VP9_SEG_LVL_REF_FRAME] = val;
} else {
params->feature_data[i][GST_VP9_SEG_LVL_REF_FRAME] = 0;
}
VP9_READ_BIT (params->feature_enabled[i][GST_VP9_SEG_SEG_LVL_SKIP]);