mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 20:21:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtcpbuffer: improve bye parsing

Browse source 
It is an error to ask for a non-existing BYE SSRC, the caller should
check the SSRC count first.
This commit is contained in:
Wim Taymans 2013-08-26 11:46:11 +02:00
parent 3c66c2a43d
commit b848f38215
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst-libs/gst/rtp/gstrtcpbuffer.c
View file

@ -1423,17 +1423,12 @@ gst_rtcp_packet_bye_get_nth_ssrc (GstRTCPPacket * packet, guint nth)
guint8 *data; guint8 *data;
guint offset; guint offset;
guint32 ssrc; guint32 ssrc;
guint8 sc;
g_return_val_if_fail (packet != NULL, 0); g_return_val_if_fail (packet != NULL, 0);
g_return_val_if_fail (packet->type == GST_RTCP_TYPE_BYE, 0); g_return_val_if_fail (packet->type == GST_RTCP_TYPE_BYE, 0);
g_return_val_if_fail (packet->rtcp != NULL, 0); g_return_val_if_fail (packet->rtcp != NULL, 0);
g_return_val_if_fail (packet->rtcp->map.flags & GST_MAP_READ, 0); g_return_val_if_fail (packet->rtcp->map.flags & GST_MAP_READ, 0);
g_return_val_if_fail (nth < packet->count, 0);
/* get amount of sources and check that we don't read too much */
sc = packet->count;
if (nth >= sc)
return 0;
/* get offset in 32-bits words into packet, skip the header */ /* get offset in 32-bits words into packet, skip the header */
offset = 1 + nth; offset = 1 + nth;