mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 17:50:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

aggregator: Ensure that the source pad is created as a GstAggregatorPad if no type is given in the pad template

Browse source 
Otherwise we would create a GstPad and that causes invalid memory
accesses later.
This commit is contained in:
Sebastian Dröge 2019-08-13 19:55:59 +03:00 committed by Sebastian Dröge
parent b7c1195f29
commit b8455445c5
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libs/gst/base/gstaggregator.c
View file

@ -2441,6 +2441,7 @@ gst_aggregator_init (GstAggregator * self, GstAggregatorClass * klass)
{
GstPadTemplate *pad_template;
GstAggregatorPrivate *priv;
GType pad_type;
g_return_if_fail (klass->aggregate != NULL);
@ -2460,7 +2461,13 @@ gst_aggregator_init (GstAggregator * self, GstAggregatorClass * klass)
self->priv->peer_latency_max = self->priv->sub_latency_max = 0;
self->priv->has_peer_latency = FALSE;
self->srcpad = gst_pad_new_from_template (pad_template, "src");
pad_type =
GST_PAD_TEMPLATE_GTYPE (pad_template) ==
G_TYPE_NONE ? GST_TYPE_AGGREGATOR_PAD :
GST_PAD_TEMPLATE_GTYPE (pad_template);
self->srcpad =
g_object_new (pad_type, "name", "src", "direction", GST_PAD_SRC,
"template", pad_template, NULL);
gst_aggregator_reset_flow_values (self);