mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-24 02:31:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

event: fix leak in gst_event_parse_stream_start()

Browse source 
gst_structure_id_get() will make a copy of the string
extracted, but we're assigning it to a const gchar *.
This commit is contained in:
Tim-Philipp Müller 2012-08-12 18:31:13 +01:00
parent 79c0d2a276
commit b695d442fc
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/gstevent.c
View file

@ -1634,21 +1634,25 @@ gst_event_new_stream_start (const gchar * stream_id)
* @event: a stream-start event. * @event: a stream-start event.
* @stream_id: (out): pointer to store the stream-id * @stream_id: (out): pointer to store the stream-id
* *
* Parse a stream-id @event and store the result in the given @stream_id location. * Parse a stream-id @event and store the result in the given @stream_id
* location. The string stored in @stream_id must not be modified and will
* remain valid only until @event gets freed. Make a copy if you want to
* modify it or store it for later use.
*/ */
void void
gst_event_parse_stream_start (GstEvent * event, const gchar ** stream_id) gst_event_parse_stream_start (GstEvent * event, const gchar ** stream_id)
{ {
const GstStructure *structure; const GstStructure *structure;
const GValue *val;
g_return_if_fail (event != NULL); g_return_if_fail (event != NULL);
g_return_if_fail (GST_EVENT_TYPE (event) == GST_EVENT_STREAM_START); g_return_if_fail (GST_EVENT_TYPE (event) == GST_EVENT_STREAM_START);
structure = gst_event_get_structure (event); structure = gst_event_get_structure (event);
val = gst_structure_id_get_value (structure, GST_QUARK (STREAM_ID));
if (stream_id) if (stream_id)
gst_structure_id_get (structure, *stream_id = g_value_get_string (val);
GST_QUARK (STREAM_ID), G_TYPE_STRING, stream_id, NULL);
} }
/** /**