mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 16:50:47 +00:00
Code Issues 1 Projects Releases Wiki Activity

pesparse: Be a bit more permissive with PTS/DTS parsing

Browse source 
According to the specifications a PTS_DTS_flags value of 0x01 is forbidden.
... but there are some rare files out there that do that.

Instead of erroring out, let's warn, carry on parsing accordingly.

If the packet is really corrupted there are enough checks afterward to
detect that.
This commit is contained in:
Edward Hervey 2012-05-26 14:08:41 +02:00
parent 6ea05840a4
commit b6732a27d3
1 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
gst/mpegtsdemux/pesparse.c
View file

@ -137,8 +137,9 @@ mpegts_parse_pes_header (const guint8 * data, gsize length, PESHeader * res,
/* PTS/DTS */
/* PTS_DTS_flags == 0x01 is invalid */
if (G_UNLIKELY ((flags >> 6) == 0x01))
goto bad_PTS_DTS_flags;
if (G_UNLIKELY ((flags >> 6) == 0x01)) {
GST_WARNING ("Invalid PTS_DTS_flag (0x01 is forbidden)");
}
if ((flags & 0x80) == 0x80) {
/* PTS */
@ -150,17 +151,18 @@ mpegts_parse_pes_header (const guint8 * data, gsize length, PESHeader * res,
GST_LOG ("PTS %" G_GUINT64_FORMAT " %" GST_TIME_FORMAT,
res->PTS, GST_TIME_ARGS (MPEGTIME_TO_GSTTIME (res->PTS)));
if ((flags & 0x40) == 0x40) {
/* DTS */
if (G_UNLIKELY (length < 5))
goto need_more_data;
}
READ_TS (data, res->DTS, bad_DTS_value);
length -= 5;
if ((flags & 0x40) == 0x40) {
/* DTS */
if (G_UNLIKELY (length < 5))
goto need_more_data;
GST_LOG ("DTS %" G_GUINT64_FORMAT " %" GST_TIME_FORMAT,
res->DTS, GST_TIME_ARGS (MPEGTIME_TO_GSTTIME (res->DTS)));
}
READ_TS (data, res->DTS, bad_DTS_value);
length -= 5;
GST_LOG ("DTS %" G_GUINT64_FORMAT " %" GST_TIME_FORMAT,
res->DTS, GST_TIME_ARGS (MPEGTIME_TO_GSTTIME (res->DTS)));
}
if (flags & 0x20) {
@ -380,10 +382,6 @@ bad_marker_1:
val8);
return PES_PARSING_BAD;
bad_PTS_DTS_flags:
GST_WARNING ("Invalid '0x01' PTS_DTS_flags");
return PES_PARSING_BAD;
bad_PTS_value:
GST_WARNING ("bad PTS value");
return PES_PARSING_BAD;