mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-04 05:35:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

mxftypes: Don't store pointers in stack allocated guints

Browse source 
This works usually in this place, unless the compiler optimizes things in
interesting ways in which case it causes stack corruption and crashes later.

The compiler in question here is clang with -O1, which seems to pack the stack
a bit more and causes writing to the guint as pointer to overwrite map.memory,
which then later crashes during unmapping of the memory.
This commit is contained in:
Sebastian Dröge 2016-01-07 18:10:49 +02:00
parent 5a1953b31f
commit b6696122a0
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/mxf/mxftypes.c
View file

@ -1585,15 +1585,14 @@ mxf_primer_pack_to_buffer (const MXFPrimerPack * pack)
data += 8;
if (pack->mappings) {
guint local_tag;
gpointer local_tag;
MXFUL *ul;
GHashTableIter iter;
g_hash_table_iter_init (&iter, pack->mappings);
while (g_hash_table_iter_next (&iter, (gpointer) & local_tag,
(gpointer) & ul)) {
GST_WRITE_UINT16_BE (data, local_tag);
while (g_hash_table_iter_next (&iter, &local_tag, (gpointer) & ul)) {
GST_WRITE_UINT16_BE (data, GPOINTER_TO_UINT (local_tag));
memcpy (data + 2, ul, 16);
data += 18;
}