mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-28 11:10:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

glfilter: Only add parent meta if inbuf != outbuf

Browse source 
This was causing a memory leak in cases like `gltestsrc ! gltransformation scale-x=0.5 ! glimagesink`.
Parent meta was being added in assumption that those buffers are different, which was not the case here,
creating a reference loop and never freeing the buffer.

Co-authored-by: Matthew Waters <matthew@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5453>
This commit is contained in:
Piotr Brzeziński 2023-10-09 14:48:35 +02:00 committed by Tim-Philipp Müller
parent 019430949c
commit b5ca7eba4e
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
subprojects/gst-plugins-base/gst-libs/gst/gl/gstglfilter.c
View file

@ -1038,6 +1038,7 @@ gst_gl_filter_transform (GstBaseTransform * bt, GstBuffer * inbuf,
* buffer meta to hold one reference of inbuf, this can avoid this * buffer meta to hold one reference of inbuf, this can avoid this
* buffer sync problem. * buffer sync problem.
*/ */
if (inbuf != outbuf)
gst_buffer_add_parent_buffer_meta (outbuf, inbuf); gst_buffer_add_parent_buffer_meta (outbuf, inbuf);
return ret ? GST_FLOW_OK : GST_FLOW_ERROR; return ret ? GST_FLOW_OK : GST_FLOW_ERROR;