mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-04 06:29:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/mpegvideoparse/mpegvideoparse.c: Fix leaking caps.

Browse source 
Original commit message from CVS:
* gst/mpegvideoparse/mpegvideoparse.c:
(mpegvideoparse_handle_sequence), (mpegvideoparse_drain_avail),
(gst_mpegvideoparse_change_state):
Fix leaking caps.
Fix potential buffer leak in forward mode.
Cleanup queues when going to READY. Fixes #515815.
This commit is contained in:
Wim Taymans 2008-02-12 10:57:27 +00:00
parent 571a20f205
commit b5708310bb
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2008-02-12 Wim Taymans <wim.taymans@collabora.co.uk>
* gst/mpegvideoparse/mpegvideoparse.c:
(mpegvideoparse_handle_sequence), (mpegvideoparse_drain_avail),
(gst_mpegvideoparse_change_state):
Fix leaking caps.
Fix potential buffer leak in forward mode.
Cleanup queues when going to READY. Fixes #515815.
2008-02-12 Sebastian Dröge <slomo@circular-chaos.org> 2008-02-12 Sebastian Dröge <slomo@circular-chaos.org>
* docs/plugins/gst-plugins-bad-plugins-docs.sgml: * docs/plugins/gst-plugins-bad-plugins-docs.sgml:

11
gst/mpegvideoparse/mpegvideoparse.c
View file

@ -231,8 +231,11 @@ mpegvideoparse_handle_sequence (MpegVideoParse * mpegvideoparse,
"codec_data", GST_TYPE_BUFFER, seq_buf, NULL); "codec_data", GST_TYPE_BUFFER, seq_buf, NULL);
GST_DEBUG ("New mpegvideoparse caps: %" GST_PTR_FORMAT, caps); GST_DEBUG ("New mpegvideoparse caps: %" GST_PTR_FORMAT, caps);
if (!gst_pad_set_caps (mpegvideoparse->srcpad, caps)) if (!gst_pad_set_caps (mpegvideoparse->srcpad, caps)) {
gst_caps_unref (caps);
return FALSE; return FALSE;
}
gst_caps_unref (caps);
/* And update the new_hdr into our stored version */ /* And update the new_hdr into our stored version */
mpegvideoparse->seq_hdr = new_hdr; mpegvideoparse->seq_hdr = new_hdr;
@ -372,12 +375,15 @@ mpegvideoparse_drain_avail (MpegVideoParse * mpegvideoparse)
mpegvideoparse->need_discont = FALSE; mpegvideoparse->need_discont = FALSE;
} }
res = gst_pad_push (mpegvideoparse->srcpad, buf); res = gst_pad_push (mpegvideoparse->srcpad, buf);
buf = NULL;
} }
/* Advance to the next data block */ /* Advance to the next data block */
mpeg_packetiser_next_block (&mpegvideoparse->packer); mpeg_packetiser_next_block (&mpegvideoparse->packer);
cur = mpeg_packetiser_get_block (&mpegvideoparse->packer, &buf); cur = mpeg_packetiser_get_block (&mpegvideoparse->packer, &buf);
}; }
if (buf != NULL)
gst_buffer_unref (buf);
return res; return res;
} }
@ -824,6 +830,7 @@ gst_mpegvideoparse_change_state (GstElement * element,
switch (transition) { switch (transition) {
case GST_STATE_CHANGE_PAUSED_TO_READY: case GST_STATE_CHANGE_PAUSED_TO_READY:
mpv_parse_reset (mpegvideoparse); mpv_parse_reset (mpegvideoparse);
gst_mpegvideoparse_flush (mpegvideoparse);
break; break;
default: default:
break; break;