mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-17 21:06:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: check return calling of gst_navigation_event_parse.*

Browse source 
This issue was detected by Coverity.

If the function returns an error value, the error value may be mistaken
for a normal value.

In cb_mouse_event: Value returned from a function is not checked for
errors before being used
This commit is contained in:
Víctor Manuel Jáquez Leal 2019-12-17 13:09:58 +01:00
parent 2cad0e5629
commit b55b0538c9
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/check/elements/vaapipostproc.c
View file

@ -125,18 +125,23 @@ static GstPadProbeReturn
cb_mouse_event (GstPad * pad, GstPadProbeInfo * info, gpointer data)
{
VppTestCoordinate *coord = data;
gdouble x = 0, y = 0;
GstEvent *event = GST_PAD_PROBE_INFO_EVENT (info);
if (GST_EVENT_TYPE (event) == GST_EVENT_NAVIGATION) {
switch (gst_navigation_event_get_type (event)) {
case GST_NAVIGATION_EVENT_MOUSE_MOVE:
gst_navigation_event_parse_mouse_move_event (event, &coord->x,
&coord->y);
if (gst_navigation_event_parse_mouse_move_event (event, &x, &y)) {
coord->x = x;
coord->y = y;
}
break;
case GST_NAVIGATION_EVENT_MOUSE_BUTTON_PRESS:
case GST_NAVIGATION_EVENT_MOUSE_BUTTON_RELEASE:
gst_navigation_event_parse_mouse_button_event (event, NULL, &coord->x,
&coord->y);
if (gst_navigation_event_parse_mouse_button_event (event, NULL, &x, &y)) {
coord->x = x;
coord->y = y;
}
break;
default:
break;
@ -152,7 +157,7 @@ vpp_test_mouse_events (VppTestContext * ctx,
{
GstStructure *structure;
GstEvent *event;
VppTestCoordinate probed;
VppTestCoordinate probed = { 0, };
guint i, j;
/* probe mouse events propagated up from vaapipostproc */