mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 22:36:33 +00:00
Code Issues 1 Projects Releases Wiki Activity

identity,clocksync: Fix timestamping inside single segment in reverse playback

Browse source 
In reverse playback, buffers are played back from buffer.stop
(buffer.pts + buffer.duration) to buffer.pts running times which
mean that we need to use the buffer end running time as a buffer
timestsamp, not the buffer pts when using a single segment in reverse
playback.

This is now being tested in
`validate.test.identity.reverse_single_segment`

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/450>
This commit is contained in:
Thibault Saunier 2020-04-28 13:28:32 -04:00 committed by GStreamer Merge Bot
parent 39b9cc554c
commit b517b59171
2 changed files with 30 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
plugins/elements/gstclocksync.c
View file

@ -338,10 +338,21 @@ gst_clock_sync_chain (GstPad * pad, GstObject * parent, GstBuffer * buf)
GstClockTime runtimestamp = 0; GstClockTime runtimestamp = 0;
GstClockTime rundts, runpts; GstClockTime rundts, runpts;
rundts = gst_segment_to_running_time (&clocksync->segment, if (clocksync->segment.rate > 0.0) {
GST_FORMAT_TIME, GST_BUFFER_DTS (buf)); rundts = gst_segment_to_running_time (&clocksync->segment,
runpts = gst_segment_to_running_time (&clocksync->segment, GST_FORMAT_TIME, GST_BUFFER_DTS (buf));
GST_FORMAT_TIME, GST_BUFFER_PTS (buf)); runpts = gst_segment_to_running_time (&clocksync->segment,
GST_FORMAT_TIME, GST_BUFFER_PTS (buf));
} else {
runpts = gst_segment_to_running_time (&clocksync->segment,
GST_FORMAT_TIME, GST_CLOCK_TIME_IS_VALID (buf->duration)
&& GST_CLOCK_TIME_IS_VALID (buf->pts) ? buf->pts +
buf->duration : buf->pts);
rundts = gst_segment_to_running_time (&clocksync->segment,
GST_FORMAT_TIME, GST_CLOCK_TIME_IS_VALID (buf->duration)
&& GST_CLOCK_TIME_IS_VALID (buf->dts) ? buf->dts +
buf->duration : buf->dts);
}
if (GST_CLOCK_TIME_IS_VALID (rundts)) if (GST_CLOCK_TIME_IS_VALID (rundts))
runtimestamp = rundts; runtimestamp = rundts;

19
plugins/elements/gstidentity.c
View file

@ -687,10 +687,21 @@ gst_identity_transform_ip (GstBaseTransform * trans, GstBuffer * buf)
g_signal_emit (identity, gst_identity_signals[SIGNAL_HANDOFF], 0, buf); g_signal_emit (identity, gst_identity_signals[SIGNAL_HANDOFF], 0, buf);
if (trans->segment.format == GST_FORMAT_TIME) { if (trans->segment.format == GST_FORMAT_TIME) {
rundts = gst_segment_to_running_time (&trans->segment, if (trans->segment.rate > 0) {
GST_FORMAT_TIME, GST_BUFFER_DTS (buf)); runpts = gst_segment_to_running_time (&trans->segment,
runpts = gst_segment_to_running_time (&trans->segment, GST_FORMAT_TIME, GST_BUFFER_PTS (buf));
GST_FORMAT_TIME, GST_BUFFER_PTS (buf)); rundts = gst_segment_to_running_time (&trans->segment,
GST_FORMAT_TIME, GST_BUFFER_DTS (buf));
} else {
runpts = gst_segment_to_running_time (&trans->segment,
GST_FORMAT_TIME, GST_CLOCK_TIME_IS_VALID (buf->duration)
&& GST_CLOCK_TIME_IS_VALID (buf->pts) ? buf->pts +
buf->duration : buf->pts);
rundts = gst_segment_to_running_time (&trans->segment,
GST_FORMAT_TIME, GST_CLOCK_TIME_IS_VALID (buf->duration)
&& GST_CLOCK_TIME_IS_VALID (buf->dts) ? buf->dts +
buf->duration : buf->dts);
}
} }
if (GST_CLOCK_TIME_IS_VALID (rundts)) if (GST_CLOCK_TIME_IS_VALID (rundts))