mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

decklinksink: Add some FIXME comments about synchronization

Browse source
This commit is contained in:
Sebastian Dröge 2014-11-14 11:02:01 +01:00
parent 50c4ea54f6
commit b4695f60e5
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sys/decklink/gstdecklinksink.cpp
View file

@ -481,6 +481,10 @@ gst_decklink_sink_videosink_chain (GstPad * pad, GstObject * parent,
gst_buffer_unref (buffer); gst_buffer_unref (buffer);
g_mutex_lock (&decklinksink->mutex); g_mutex_lock (&decklinksink->mutex);
/* FIXME: This is not correct as it assumes that the decklink clock
* has the exact same value as the pipeline clock at any time. Not
* only the same rate!
*/
while (decklinksink->queued_frames > 2 && !decklinksink->stop) { while (decklinksink->queued_frames > 2 && !decklinksink->stop) {
g_cond_wait (&decklinksink->cond, &decklinksink->mutex); g_cond_wait (&decklinksink->cond, &decklinksink->mutex);
} }
@ -628,6 +632,10 @@ gst_decklink_sink_audiosink_chain (GstPad * pad, GstObject * parent,
return GST_FLOW_FLUSHING; return GST_FLOW_FLUSHING;
g_mutex_lock (&decklinksink->audio_mutex); g_mutex_lock (&decklinksink->audio_mutex);
/* FIXME: This is not correct as it assumes that the decklink clock
* has the exact same value as the pipeline clock at any time. Not
* only the same rate!
*/
while (!decklinksink->stop && while (!decklinksink->stop &&
gst_adapter_available (decklinksink->audio_adapter) > 1600 * 4 * 2) { gst_adapter_available (decklinksink->audio_adapter) > 1600 * 4 * 2) {
g_cond_wait (&decklinksink->audio_cond, &decklinksink->audio_mutex); g_cond_wait (&decklinksink->audio_cond, &decklinksink->audio_mutex);
@ -725,6 +733,10 @@ Output::RenderAudioSamples (bool preroll)
if (n > 0) { if (n > 0) {
data = gst_adapter_map (decklinksink->audio_adapter, n); data = gst_adapter_map (decklinksink->audio_adapter, n);
/* FIXME: This is not correct. We assume here that the decklink
* clock runs at the same rate as the pipeline clock and that
* the input stream has no discontinuities at all
*/
ret = decklinksink->output->ScheduleAudioSamples ((void *) data, n / 4, ret = decklinksink->output->ScheduleAudioSamples ((void *) data, n / 4,
0, 0, &samplesWritten); 0, 0, &samplesWritten);