mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 06:46:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

codec-utils: Avoid out-of-bounds error

Browse source 
For artificial input (in unit tests), all six bytes of
constraint_indicator_flags in hevc_caps_get_mime_codec() can be
zero. Add a guard against an out-of-bounds error that occurred in that
case. Change variables to signed int so comparison with -1 works.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1677>
This commit is contained in:
David Svensson Fors 2022-02-07 09:30:58 +01:00 committed by GStreamer Marge Bot
parent 7a9e11ae1b
commit b3d300bc26
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subprojects/gst-plugins-base/gst-libs/gst/pbutils/codec-utils.c
View file

@ -2380,7 +2380,7 @@ hevc_caps_get_mime_codec (GstCaps * caps, gchar ** mime_codec)
guint32 compat_flag_parameter = 0;
GString *codec_string;
const guint8 *profile_tier_level;
unsigned last_flag_index;
gint last_flag_index;
caps_st = gst_caps_get_structure (caps, 0);
codec_data_value = gst_structure_get_value (caps_st, "codec_data");
@ -2447,9 +2447,10 @@ hevc_caps_get_mime_codec (GstCaps * caps, gchar ** mime_codec)
* of each byte separated by a period; trailing bytes that are zero may be omitted.
*/
last_flag_index = 5;
while ((int) (constraint_indicator_flags[last_flag_index]) == 0)
while (last_flag_index >= 0
&& (int) (constraint_indicator_flags[last_flag_index]) == 0)
--last_flag_index;
for (unsigned i = 0; i <= last_flag_index; ++i) {
for (gint i = 0; i <= last_flag_index; ++i) {
g_string_append_printf (codec_string, ".%02X",
constraint_indicator_flags[i]);
}