mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 01:00:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

filter: fix memory leak of VPP operations.

Browse source 
Fix ensure_operations() to release the VPP operations array if non
NULL, prior to returning to the caller. The former function was also
renamed to a more meaningful get_operations() since the caller owns
the returned array that needs to be released.
This commit is contained in:
Gwenole Beauchesne 2013-10-01 18:26:39 +02:00
parent e05e65e349
commit b242c5874b
1 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
gst-libs/gst/vaapi/gstvaapifilter.c
View file

@ -633,7 +633,7 @@ error:
/* Determine the set of supported VPP operations by the specific
filter, or known to this library if filter is NULL */
static GPtrArray *
ensure_operations(GstVaapiFilter *filter)
get_operations(GstVaapiFilter *filter)
{
#if USE_VA_VPP
GPtrArray *ops;
@ -649,6 +649,27 @@ ensure_operations(GstVaapiFilter *filter)
return NULL;
}
/* Ensure the set of supported VPP operations is cached into the
GstVaapiFilter::operations member */
static inline gboolean
ensure_operations(GstVaapiFilter *filter)
{
GPtrArray *ops;
if (!filter)
return FALSE;
if (filter->operations)
return TRUE;
ops = get_operations(filter);
if (!ops)
return FALSE;
g_ptr_array_unref(ops);
return TRUE;
}
/* Find whether the VPP operation is supported or not */
GstVaapiFilterOpData *
find_operation(GstVaapiFilter *filter, GstVaapiFilterOp op)
@ -1092,11 +1113,7 @@ gst_vaapi_filter_replace(GstVaapiFilter **old_filter_ptr,
GPtrArray *
gst_vaapi_filter_get_operations(GstVaapiFilter *filter)
{
#if USE_VA_VPP
return ensure_operations(filter);
#else
return NULL;
#endif
return get_operations(filter);
}
/**