mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtc/nice: fix small leak of split strings

Browse source 
g_strfreev previously stopped at our manual NULL-termination. Fix by
restoring the pointer after joining.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3188>
This commit is contained in:
Mathieu Duponchelle 2022-10-14 18:51:43 +02:00 committed by GStreamer Marge Bot
parent 48e097c315
commit b10e0efd3a
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
View file

@ -730,6 +730,7 @@ get_candidate_address (const gchar * candidate, gchar ** prefix,
gchar ** address, gchar ** postfix) gchar ** address, gchar ** postfix)
{ {
char **tokens = NULL; char **tokens = NULL;
char *tmp_address = NULL;
if (!g_str_has_prefix (candidate, "a=candidate:")) { if (!g_str_has_prefix (candidate, "a=candidate:")) {
GST_ERROR ("candidate \"%s\" does not start with \"a=candidate:\"", GST_ERROR ("candidate \"%s\" does not start with \"a=candidate:\"",
@ -748,14 +749,18 @@ get_candidate_address (const gchar * candidate, gchar ** prefix,
goto failure; goto failure;
} }
tmp_address = tokens[4];
if (address) if (address)
*address = g_strdup (tokens[4]); *address = g_strdup (tmp_address);
tokens[4] = NULL; tokens[4] = NULL;
if (prefix) if (prefix)
*prefix = g_strjoinv (" ", tokens); *prefix = g_strjoinv (" ", tokens);
if (postfix) if (postfix)
*postfix = g_strdup (tokens[5]); *postfix = g_strdup (tokens[5]);
tokens[4] = tmp_address;
g_strfreev (tokens); g_strfreev (tokens);
return TRUE; return TRUE;