ext/vorbis/vorbisenc.c: Minimal fix for bug #320200: set the min/max bitrate in the correct units. A better fix would...

Original commit message from CVS:
* ext/vorbis/vorbisenc.c: (gst_vorbisenc_setup):
Minimal fix for bug #320200: set the min/max bitrate in the correct
units. A better fix would be to upgrade to the RATEMANAGE2
interface, rather than using the deprecated interface used here, but
that would require an update in our libvorbis dependency (to 1.1),
which is probably undesirable.
This commit is contained in:
Michael Smith 2005-11-21 15:16:29 +00:00
parent 1cc82e9138
commit afa20a78b2
2 changed files with 11 additions and 4 deletions

View file

@ -1,3 +1,12 @@
2005-11-21 Michael Smith <msmith@fluendo.com>
* ext/vorbis/vorbisenc.c: (gst_vorbisenc_setup):
Minimal fix for bug #320200: set the min/max bitrate in the correct
units. A better fix would be to upgrade to the RATEMANAGE2
interface, rather than using the deprecated interface used here, but
that would require an update in our libvorbis dependency (to 1.1),
which is probably undesirable.
2005-11-21 Jan Schmidt <thaytan@mad.scientist.com> 2005-11-21 Jan Schmidt <thaytan@mad.scientist.com>
* ext/libvisual/visual.c: (get_buffer): * ext/libvisual/visual.c: (get_buffer):

View file

@ -732,10 +732,8 @@ gst_vorbisenc_setup (GstVorbisEnc * vorbisenc)
vorbis_encode_ctl (&vorbisenc->vi, OV_ECTL_RATEMANAGE_GET, &ai); vorbis_encode_ctl (&vorbisenc->vi, OV_ECTL_RATEMANAGE_GET, &ai);
/* the bitrates used by libvorbisenc are in kbit/sec, ours in bit/sec ai.bitrate_hard_min = vorbisenc->min_bitrate;
* also remember that in telecom kbit/sec is 1000 bit/sec */ ai.bitrate_hard_max = vorbisenc->max_bitrate;
ai.bitrate_hard_min = vorbisenc->min_bitrate / 1000;
ai.bitrate_hard_max = vorbisenc->max_bitrate / 1000;
ai.management_active = 1; ai.management_active = 1;
vorbis_encode_ctl (&vorbisenc->vi, OV_ECTL_RATEMANAGE_SET, &ai); vorbis_encode_ctl (&vorbisenc->vi, OV_ECTL_RATEMANAGE_SET, &ai);