mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 01:02:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

videomixer: GstVideoConverter currently can't rescale and will assert

Browse source 
Leads to ugly assertions instead of properly erroring out:
CRITICAL **: gst_video_converter_new: assertion 'in_info->width == out_info->width' failed
This commit is contained in:
Sebastian Dröge 2014-10-01 17:12:59 +03:00
parent 23a3377b1e
commit af7916ca4a
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/videomixer/videomixer2.c
View file

@ -447,7 +447,12 @@ gst_videomixer2_update_converters (GstVideoMixer2 * mix)
GST_DEBUG_OBJECT (pad, "This pad will be converted from %d to %d",
GST_VIDEO_INFO_FORMAT (&pad->info),
GST_VIDEO_INFO_FORMAT (&best_info));
pad->convert = gst_video_converter_new (&pad->info, &best_info, NULL);
/* TODO: GstVideoConverter currently can't rescale! */
if (pad->info.width == best_info.width &&
pad->info.height == best_info.height &&
pad->info.par_n == best_info.par_n &&
pad->info.par_d == best_info.par_d)
pad->convert = gst_video_converter_new (&pad->info, &best_info, NULL);
pad->need_conversion_update = TRUE;
if (!pad->convert) {
g_free (colorimetry);