mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 14:06:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspsrc: Fix up sendonly/recvonly attribute handling

Browse source 
We can't handle recvonly streams, sendonly streams are perfectly fine.

The direction is the one from the point of view of the SDP offerer
(i.e. the RTSP server), and a recvonly stream would be one where the
server expects us to send media.

RFC 3264, section 5.1:
   If the offerer wishes to only send media on a stream to its peer, it
   MUST mark the stream as sendonly with the "a=sendonly" attribute.

This is mixed up in the ONVIF streaming specification examples, but
actual implementations and conformance tools seem to not care at all
about the attributes.

https://bugzilla.gnome.org/show_bug.cgi?id=792376
This commit is contained in:
Sebastian Dröge 2018-01-22 12:24:18 +02:00
parent 129eecf012
commit af273b4de9
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/rtsp/gstrtspsrc.c
View file

@ -1705,8 +1705,8 @@ gst_rtspsrc_collect_payloads (GstRTSPSrc * src, const GstSDPMessage * sdp,
else
goto unknown_proto;
if (gst_sdp_media_get_attribute_val (media, "sendonly") != NULL)
goto sendonly_media;
if (gst_sdp_media_get_attribute_val (media, "recvonly") != NULL)
goto recvonly_media;
/* Parse global SDP attributes once */
global_caps = gst_caps_new_empty_simple ("application/x-unknown");
@ -1777,9 +1777,9 @@ unknown_proto:
GST_ERROR_OBJECT (src, "unknown proto in media: '%s'", proto);
return;
}
sendonly_media:
recvonly_media:
{
GST_DEBUG_OBJECT (src, "sendonly media ignored");
GST_DEBUG_OBJECT (src, "recvonly media ignored");
return;
}
}