mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-02 12:45:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

bad: use of g_value_dup_string

Browse source 
Use helper method to get string from GValue.
This commit is contained in:
Stéphane Cerveau 2019-12-18 15:37:03 +01:00 committed by Thibault Saunier
parent e59962850a
commit add7878e14
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/neon/gstneonhttpsrc.c
View file

@ -321,7 +321,7 @@ gst_neonhttp_src_set_property (GObject * object, guint prop_id,
} }
case PROP_USER_AGENT: case PROP_USER_AGENT:
g_free (src->user_agent); g_free (src->user_agent);
src->user_agent = g_strdup (g_value_get_string (value)); src->user_agent = g_value_dup_string (value);
break; break;
case PROP_COOKIES: case PROP_COOKIES:
if (src->cookies) if (src->cookies)

6
gst/librfb/gstrfbsrc.c
View file

@ -248,17 +248,17 @@ gst_rfb_src_set_property (GObject * object, guint prop_id,
switch (prop_id) { switch (prop_id) {
case PROP_HOST: case PROP_HOST:
src->host = g_strdup (g_value_get_string (value)); src->host = g_value_dup_string (value);;
break; break;
case PROP_PORT: case PROP_PORT:
src->port = g_value_get_int (value); src->port = g_value_get_int (value);
break; break;
case PROP_VERSION: case PROP_VERSION:
gst_rfb_property_set_version (src, g_strdup (g_value_get_string (value))); gst_rfb_property_set_version (src, g_value_dup_string (value));
break; break;
case PROP_PASSWORD: case PROP_PASSWORD:
g_free (src->decoder->password); g_free (src->decoder->password);
src->decoder->password = g_strdup (g_value_get_string (value)); src->decoder->password = g_value_dup_string (value);
break; break;
case PROP_OFFSET_X: case PROP_OFFSET_X:
src->decoder->offset_x = g_value_get_int (value); src->decoder->offset_x = g_value_get_int (value);

2
sys/directsound/gstdirectsoundsrc.c
View file

@ -262,7 +262,7 @@ gst_directsound_src_set_property (GObject * object, guint prop_id,
src->device_name = NULL; src->device_name = NULL;
} }
if (g_value_get_string (value)) { if (g_value_get_string (value)) {
src->device_name = g_strdup (g_value_get_string (value)); src->device_name = g_value_dup_string (value);
} }
break; break;
case PROP_VOLUME: case PROP_VOLUME:

4
sys/dshowsrcwrapper/gstdshowaudiosrc.cpp
View file

@ -220,7 +220,7 @@ gst_dshowaudiosrc_set_property (GObject * object, guint prop_id,
src->device = NULL; src->device = NULL;
} }
if (g_value_get_string (value)) { if (g_value_get_string (value)) {
src->device = g_strdup (g_value_get_string (value)); src->device = g_value_dup_string (value);;
} }
break; break;
} }
@ -231,7 +231,7 @@ gst_dshowaudiosrc_set_property (GObject * object, guint prop_id,
src->device_name = NULL; src->device_name = NULL;
} }
if (g_value_get_string (value)) { if (g_value_get_string (value)) {
src->device_name = g_strdup (g_value_get_string (value)); src->device_name = g_value_dup_string (value);;
} }
break; break;
} }